path: root/src/network
diff options
authorJeongmin Kim <>2014-11-11 08:49:25 +0900
committerJeongmin Kim <>2014-12-20 04:20:07 +0100
commit741dd3da33920dd1c2e4485d85f7693d394798ce (patch)
treead49d21a3bc07b79ff6caeee4ec71d9127fff293 /src/network
parenta31b75b766b87d0210ed174f587aee33ad639f9b (diff)
QNetworkDiskCache: Do not store set-cookie headers of the response in disk cache.
The cookies may contain sensitive information. so we should not store cookies in disk cache. Task-number: QTBUG-42546 Change-Id: I6331bdd766445af41f55bfaf0e9132b75dd7957f Reviewed-by: Jeongmin Kim <> Reviewed-by: Thiago Macieira <>
Diffstat (limited to 'src/network')
1 files changed, 3 insertions, 0 deletions
diff --git a/src/network/access/qnetworkreplyhttpimpl.cpp b/src/network/access/qnetworkreplyhttpimpl.cpp
index 836b3c3fa4..4ce7303dbb 100644
--- a/src/network/access/qnetworkreplyhttpimpl.cpp
+++ b/src/network/access/qnetworkreplyhttpimpl.cpp
@@ -1399,6 +1399,9 @@ QNetworkCacheMetaData QNetworkReplyHttpImplPrivate::fetchCacheMetaData(const QNe
if (hop_by_hop)
+ if (header == "set-cookie")
+ continue;
// for 4.6.0, we were planning to not store the date header in the
// cached resource; through that we planned to reduce the number
// of writes to disk when using a QNetworkDiskCache (i.e. don't