diff options
author | Juha Vuolle <juha.vuolle@qt.io> | 2024-02-29 13:18:47 +0200 |
---|---|---|
committer | Juha Vuolle <juha.vuolle@qt.io> | 2024-03-05 08:10:17 +0200 |
commit | 9c0a79d323500d07fb8b95656b9013dc118b9fa3 (patch) | |
tree | 8ea9f3e93e14cf495df2767cab79911605c5883e /src/network | |
parent | de37316160920f88101fbb59e32b401d139f2e80 (diff) |
DRY QHttpHeaders::values() implementation
Pick-to: 6.7
Task-number: QTBUG-122020
Change-Id: I7401eef86b133d33f32cd786dffe9a06c4ac7aba
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/network')
-rw-r--r-- | src/network/access/qhttpheaders.cpp | 29 |
1 files changed, 14 insertions, 15 deletions
diff --git a/src/network/access/qhttpheaders.cpp b/src/network/access/qhttpheaders.cpp index 18b76a3035..b0aafd2e17 100644 --- a/src/network/access/qhttpheaders.cpp +++ b/src/network/access/qhttpheaders.cpp @@ -791,6 +791,7 @@ public: static void removeAll(Self &d, const HeaderName &name); void combinedValue(const HeaderName &name, QByteArray &result) const; + void values(const HeaderName &name, QList<QByteArray> &result) const; QList<Header> headers; }; @@ -833,6 +834,14 @@ void QHttpHeadersPrivate::combinedValue(const HeaderName &name, QByteArray &resu } } +void QHttpHeadersPrivate::values(const HeaderName &name, QList<QByteArray> &result) const +{ + for (const auto &h : std::as_const(headers)) { + if (h.name == name) + result.append(h.value); + } +} + /*! Creates a new QHttpHeaders object. */ @@ -1308,12 +1317,7 @@ QList<QByteArray> QHttpHeaders::values(QAnyStringView name) const if (isEmpty()) return result; - const HeaderName hname(name); - - for (const auto &h : std::as_const(d->headers)) { - if (h.name == hname) - result.append(h.value); - } + d->values(HeaderName{name}, result); return result; } @@ -1322,17 +1326,12 @@ QList<QByteArray> QHttpHeaders::values(QAnyStringView name) const */ QList<QByteArray> QHttpHeaders::values(WellKnownHeader name) const { - QList<QByteArray> values; + QList<QByteArray> result; if (isEmpty()) - return values; - - const HeaderName hname(name); + return result; - for (const auto &h : std::as_const(d->headers)) { - if (h.name == hname) - values.append(h.value); - } - return values; + d->values(HeaderName{name}, result); + return result; } /*! |