summaryrefslogtreecommitdiffstats
path: root/src/network
diff options
context:
space:
mode:
authorGabriel de Dietrich <gabriel.dedietrich@qt.io>2017-10-20 20:48:24 +0700
committerGabriel de Dietrich <gabriel.dedietrich@qt.io>2017-12-19 21:42:39 +0000
commitafb48f21c8802d75bf2f6c860862caeb4740b30d (patch)
treec810f5924f48b47cc7bc0aa8c449e0dfb3e78c03 /src/network
parente996c74164f6a161c030d3aff1348b1ef7f5da6f (diff)
QCocoaNSMenuDelegate: Improve key-equivalent logic
By using NSEvent.characters instead of NSEvent.charactersIgnoringModifiers, we may miss sending ShortcutOverride events. For example, when the user presses Cmd-Opt-o, characters will be "ø" (on a US keyboard layout) and therefore we'll be looking for the wrong key-equivalent among the menu items. We only fall back on the modified string when the search on the unmodified string fails. As and addendum, we also skip any submenu when doing the key search. This is not necessary since each menu delegate will get called eventually. Change-Id: Id793315293a02c99e99d793ad812cff7b4a47821 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
Diffstat (limited to 'src/network')
0 files changed, 0 insertions, 0 deletions