summaryrefslogtreecommitdiffstats
path: root/src/platformheaders/doc
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@qt.io>2023-06-01 11:00:26 +0200
committerMarc Mutz <marc.mutz@qt.io>2023-06-01 18:39:26 +0000
commit6f529c38ce9fcd94fc7ef74d4a1a51cb3b0cf463 (patch)
treebc2f19a4883dfda55da304d5dcc9ea9c24ccc57a /src/platformheaders/doc
parent60f739f51f28e602a3a89448d489fc13babccf35 (diff)
QVariant::fromStdVariant(): protect against accidental fromValue() ADL pick-ups
The use of unqualified fromValue(arg) in the visitor implementation invites non-QVariant fromValue(T) overloads to be found using ADL, which just happen to compile because their return value implicitly converts to QVariant (like most stuff does). To rule this out, use FQN QVariant::fromValue() to switch off ADL. [ChangeLog][QtCore][QVariant] The fromStdVariant() function used an unqualifed fromValue() call to convert each alternative type in the std::variant. It now uses qualified QVariant::fromValue() to avoid picking up unrelated fromValue() overloads whose return value just happens to implicitly convert to QVariant. Amends 5927acaf652e2dfacd777a7491c217aefd1118ef. Pick-to: 6.5 6.2 Change-Id: Ica21b08c919459d0a740af03f451e4ffe224b641 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/platformheaders/doc')
0 files changed, 0 insertions, 0 deletions