diff options
| author | Konstantin Ritt <ritt.ks@gmail.com> | 2015-01-23 13:05:12 +0400 |
|---|---|---|
| committer | Konstantin Ritt <ritt.ks@gmail.com> | 2015-02-13 16:29:16 +0000 |
| commit | 9b67d89c24666d405dd00e63bb56c924738aa002 (patch) | |
| tree | bf0c0197b68097e9aace8ac3708dcbf0e3fe0c7c /src/plugins/platforminputcontexts/compose | |
| parent | 22b5c39e8e0f4d8cb8a2b2d661e0451e01b75929 (diff) | |
Pass params of shareable type by const-ref rather than by value
...where passing them by value was not intentional.
Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/plugins/platforminputcontexts/compose')
| -rw-r--r-- | src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp | 2 | ||||
| -rw-r--r-- | src/plugins/platforminputcontexts/compose/generator/qtablegenerator.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp b/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp index 4697613833..4784a6e828 100644 --- a/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp +++ b/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp @@ -259,7 +259,7 @@ QByteArray TableGenerator::readLocaleAliases(const QByteArray &locale) return fullLocaleName; } -bool TableGenerator::processFile(QString composeFileName) +bool TableGenerator::processFile(const QString &composeFileName) { QFile composeFile(composeFileName); if (composeFile.open(QIODevice::ReadOnly)) { diff --git a/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.h b/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.h index 4ce23f4576..468da4cad1 100644 --- a/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.h +++ b/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.h @@ -103,7 +103,7 @@ public: TableState tableState() const { return m_state; } protected: - bool processFile(QString composeFileName); + bool processFile(const QString &composeFileName); void parseKeySequence(char *line); void parseIncludeInstruction(QString line); |