diff options
author | Tor Arne Vestbø <tor.arne.vestbo@qt.io> | 2022-04-21 14:46:25 +0200 |
---|---|---|
committer | Tor Arne Vestbø <tor.arne.vestbo@qt.io> | 2022-04-29 18:03:40 +0200 |
commit | 4f72db2fce963bb43dcf369673f702a90e829712 (patch) | |
tree | 7398cb4d314d6e094c2c4389507fc5a51a7dd705 /src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp | |
parent | 3aeeb8d113f740293435bae3ee1c7316fb984a60 (diff) |
Remove noop calls to QPlatformInputContext base class
Like most QPlatformFoo base classes the default implementations are
empty, or have default behavior that should be completely replaced
by subclasses.
By making it consistent across all the platform plugins when we call
base class methods, we avoid confusion of whether a base class call
is needed or not.
Change-Id: Idd8e4a6fa0e24a1dffd21b63471c9b1c2348691f
Reviewed-by: Doris Verria <doris.verria@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp')
-rw-r--r-- | src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp b/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp index b3fb88c907..900482470d 100644 --- a/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp +++ b/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp @@ -180,8 +180,6 @@ void QIBusPlatformInputContext::invokeAction(QInputMethod::Action a, int) void QIBusPlatformInputContext::reset() { - QPlatformInputContext::reset(); - if (!d->busConnected) return; @@ -192,8 +190,6 @@ void QIBusPlatformInputContext::reset() void QIBusPlatformInputContext::commit() { - QPlatformInputContext::commit(); - if (!d->busConnected) return; @@ -242,7 +238,6 @@ void QIBusPlatformInputContext::update(Qt::InputMethodQueries q) d->context->SetSurroundingText(dbusText, cursorPosition, anchorPosition); } - QPlatformInputContext::update(q); } void QIBusPlatformInputContext::cursorRectChanged() |