diff options
| author | Mathias Hasselmann <mathias.hasselmann@kdab.com> | 2015-02-09 10:10:14 +0100 |
|---|---|---|
| committer | Andreas Hartmetz <ahartmetz@gmail.com> | 2015-02-13 20:44:55 +0000 |
| commit | e300efe6eead71d89aeff4df135d54205a1f1b1a (patch) | |
| tree | d0461c4987ccead7f06be8974ff64bc61b3ac24c /src/plugins/platforms/cocoa/main.mm | |
| parent | 63e017ee7771804aac1be1ede5771e0c574c59e3 (diff) | |
OSX: Avoid !strcmp() anti pattern
People often complain that strcmp() like functions are confusing because they
return false on equality and true on difference. Rightfully, because strcmp()
like functions return three distinct values, not a boolean value. But I guess
dear reviewer, you already know that story...
Change-Id: Ie69093f61b55448010dc324d14c62faa27214238
Reviewed-by: Konstantin Ritt <ritt.ks@gmail.com>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com>
Diffstat (limited to 'src/plugins/platforms/cocoa/main.mm')
| -rw-r--r-- | src/plugins/platforms/cocoa/main.mm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/platforms/cocoa/main.mm b/src/plugins/platforms/cocoa/main.mm index 2293a071fc..c6e46ac28d 100644 --- a/src/plugins/platforms/cocoa/main.mm +++ b/src/plugins/platforms/cocoa/main.mm @@ -53,7 +53,7 @@ QPlatformIntegration * QCocoaIntegrationPlugin::create(const QString& system, co Q_UNUSED(paramList); QCocoaAutoReleasePool pool; - if (!system.compare(QLatin1String("cocoa"), Qt::CaseInsensitive)) + if (system.compare(QLatin1String("cocoa"), Qt::CaseInsensitive) == 0) return new QCocoaIntegration; return 0; |