diff options
author | Shawn Rutledge <shawn.rutledge@qt.io> | 2019-05-31 08:38:16 +0200 |
---|---|---|
committer | Shawn Rutledge <shawn.rutledge@qt.io> | 2020-06-16 22:06:56 +0200 |
commit | 6589f2ed0cf78c9b8a5bdffcdc458dc40a974c60 (patch) | |
tree | 61f29061a4cbaf925ef0ab7ba9fafc1db9ee4ef3 /src/plugins/platforms/cocoa/qnsview_tablet.mm | |
parent | 0a2e3ce85ce788b8a07380a458faf4ed3817d0c0 (diff) |
Introduce QInputDevice hierarchy; replace QTouchDevice
We have seen during the Qt 5 series that QMouseEvent::source() does
not provide enough information: if it is synthesized, it could have
come from any device for which mouse events are synthesized, not only
from a touchscreen. By providing in every QInputEvent as complete
information about the actual source device as possible, we will enable
very fine-tuned behavior in the object that handles each event.
Further, we would like to support multiple keyboards, pointing devices,
and named groups of devices that are known as "seats" in Wayland.
In Qt 5, QPA plugins registered each touchscreen as it was discovered.
Now we extend this pattern to all input devices. This new requirement
can be implemented gradually; for now, if a QTWSI input event is
received wtihout a device pointer, a default "core" device will be
created on-the-fly, and a warning emitted.
In Qt 5, QTouchEvent::TouchPoint::id() was forced to be unique even when
multiple devices were in use simultaneously. Now that each event
identifies the device it came from, this hack is no longer needed.
A stub of the new QPointerEvent is added; it will be developed further
in subsequent patches.
[ChangeLog][QtGui][QInputEvent] Every QInputEvent now carries a pointer
to an instance of QInputDevice, or the subclass QPointingDevice in case
of mouse, touch and tablet events. Each platform plugin is expected to
create the device instances, register them, and provide valid pointers
with all input events. If this is not done, warnings are emitted and
default devices are created as necessary. When the device has accurate
information, it provides the opportunity to fine-tune behavior depending
on device type and capabilities: for example if a QMouseEvent is
synthesized from a touchscreen, the recipient can see which touchscreen
it came from. Each device also has a seatName to distinguish users on
multi-user windowing systems. Touchpoint IDs are no longer unique on
their own, but the combination of ID and device is.
Fixes: QTBUG-46412
Fixes: QTBUG-72167
Task-number: QTBUG-69433
Task-number: QTBUG-52430
Change-Id: I933fb2b86182efa722037b7a33e404c5daf5292a
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Diffstat (limited to 'src/plugins/platforms/cocoa/qnsview_tablet.mm')
-rw-r--r-- | src/plugins/platforms/cocoa/qnsview_tablet.mm | 40 |
1 files changed, 21 insertions, 19 deletions
diff --git a/src/plugins/platforms/cocoa/qnsview_tablet.mm b/src/plugins/platforms/cocoa/qnsview_tablet.mm index ba1fa55892..062e147daf 100644 --- a/src/plugins/platforms/cocoa/qnsview_tablet.mm +++ b/src/plugins/platforms/cocoa/qnsview_tablet.mm @@ -1,6 +1,6 @@ /**************************************************************************** ** -** Copyright (C) 2018 The Qt Company Ltd. +** Copyright (C) 2020 The Qt Company Ltd. ** Contact: https://www.qt.io/licensing/ ** ** This file is part of the plugins of the Qt Toolkit. @@ -41,12 +41,14 @@ #ifndef QT_NO_TABLETEVENT +#include "qpointingdevice.h" + Q_LOGGING_CATEGORY(lcQpaTablet, "qt.qpa.input.tablet") struct QCocoaTabletDeviceData { - QTabletEvent::TabletDevice device; - QTabletEvent::PointerType pointerType; + QInputDevice::DeviceType device; + QPointingDevice::PointerType pointerType; uint capabilityMask; qint64 uid; }; @@ -116,7 +118,7 @@ Q_GLOBAL_STATIC(QCocoaTabletDeviceDataHash, tabletDeviceDataHash) static_cast<uint>(buttons), pressure, xTilt, yTilt, rotation); QWindowSystemInterface::handleTabletEvent(m_platformWindow->window(), timestamp, windowPoint, screenPoint, - deviceData.device, deviceData.pointerType, buttons, pressure, xTilt, yTilt, + int(deviceData.device), int(deviceData.pointerType), buttons, pressure, xTilt, yTilt, tangentialPressure, rotation, z, deviceData.uid, keyboardModifiers); return true; @@ -130,7 +132,7 @@ Q_GLOBAL_STATIC(QCocoaTabletDeviceDataHash, tabletDeviceDataHash) [self handleTabletEvent: theEvent]; } -static QTabletEvent::TabletDevice wacomTabletDevice(NSEvent *theEvent) +static QInputDevice::DeviceType wacomTabletDevice(NSEvent *theEvent) { qint64 uid = [theEvent uniqueID]; uint bits = [theEvent vendorPointingDeviceType]; @@ -141,30 +143,30 @@ static QTabletEvent::TabletDevice wacomTabletDevice(NSEvent *theEvent) bits = uid >> 32; } - QTabletEvent::TabletDevice device; + QInputDevice::DeviceType device; // Defined in the "EN0056-NxtGenImpGuideX" // on Wacom's Developer Website (www.wacomeng.com) if (((bits & 0x0006) == 0x0002) && ((bits & 0x0F06) != 0x0902)) { - device = QTabletEvent::Stylus; + device = QInputDevice::DeviceType::Stylus; } else { switch (bits & 0x0F06) { case 0x0802: - device = QTabletEvent::Stylus; + device = QInputDevice::DeviceType::Stylus; break; case 0x0902: - device = QTabletEvent::Airbrush; + device = QInputDevice::DeviceType::Airbrush; break; case 0x0004: - device = QTabletEvent::FourDMouse; + device = QInputDevice::DeviceType::Mouse; // TODO set capabilities break; case 0x0006: - device = QTabletEvent::Puck; + device = QInputDevice::DeviceType::Puck; break; case 0x0804: - device = QTabletEvent::RotationStylus; + device = QInputDevice::DeviceType::Stylus; // TODO set capability rotation break; default: - device = QTabletEvent::NoDevice; + device = QInputDevice::DeviceType::Unknown; } } return device; @@ -184,16 +186,16 @@ static QTabletEvent::TabletDevice wacomTabletDevice(NSEvent *theEvent) switch ([theEvent pointingDeviceType]) { case NSPointingDeviceTypeUnknown: default: - deviceData.pointerType = QTabletEvent::UnknownPointer; + deviceData.pointerType = QPointingDevice::PointerType::Unknown; break; case NSPointingDeviceTypePen: - deviceData.pointerType = QTabletEvent::Pen; + deviceData.pointerType = QPointingDevice::PointerType::Pen; break; case NSPointingDeviceTypeCursor: - deviceData.pointerType = QTabletEvent::Cursor; + deviceData.pointerType = QPointingDevice::PointerType::Cursor; break; case NSPointingDeviceTypeEraser: - deviceData.pointerType = QTabletEvent::Eraser; + deviceData.pointerType = QPointingDevice::PointerType::Eraser; break; } @@ -213,9 +215,9 @@ static QTabletEvent::TabletDevice wacomTabletDevice(NSEvent *theEvent) deviceId, deviceData.device, deviceData.pointerType, deviceData.uid); if (entering) { - QWindowSystemInterface::handleTabletEnterProximityEvent(timestamp, deviceData.device, deviceData.pointerType, deviceData.uid); + QWindowSystemInterface::handleTabletEnterProximityEvent(timestamp, int(deviceData.device), int(deviceData.pointerType), deviceData.uid); } else { - QWindowSystemInterface::handleTabletLeaveProximityEvent(timestamp, deviceData.device, deviceData.pointerType, deviceData.uid); + QWindowSystemInterface::handleTabletLeaveProximityEvent(timestamp, int(deviceData.device), int(deviceData.pointerType), deviceData.uid); } } @end |