diff options
author | Oliver Wolff <oliver.wolff@qt.io> | 2018-09-05 14:48:30 +0200 |
---|---|---|
committer | Oliver Wolff <oliver.wolff@qt.io> | 2018-09-26 05:41:05 +0000 |
commit | 7421a0e88208a9afe0ab360a0646bf81a84d2290 (patch) | |
tree | 0a518e15e1d4095d7710ec919b7d772bb66411b3 /src/plugins/platforms/winrt/qwinrtmessagedialoghelper.cpp | |
parent | e5b4e7a9ed5b1d65b2ea6870498d7a1a4dbb3237 (diff) |
winrt platform plugin: Fix clang warnings
Fixed warnings:
- missing override specifier
- 0 as nullptr constant
- implicit change of signedness
- non portable path to header file
Change-Id: I6977bc561176ac7804ac01325b84c15ba849bbf2
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
Reviewed-by: Andre de la Rocha <andre.rocha@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'src/plugins/platforms/winrt/qwinrtmessagedialoghelper.cpp')
-rw-r--r-- | src/plugins/platforms/winrt/qwinrtmessagedialoghelper.cpp | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/plugins/platforms/winrt/qwinrtmessagedialoghelper.cpp b/src/plugins/platforms/winrt/qwinrtmessagedialoghelper.cpp index d69c63e9a4..7016b47f7e 100644 --- a/src/plugins/platforms/winrt/qwinrtmessagedialoghelper.cpp +++ b/src/plugins/platforms/winrt/qwinrtmessagedialoghelper.cpp @@ -99,7 +99,7 @@ void QWinRTMessageDialogHelper::exec() Q_D(QWinRTMessageDialogHelper); if (!d->shown) - show(Qt::Dialog, Qt::ApplicationModal, 0); + show(Qt::Dialog, Qt::ApplicationModal, nullptr); d->loop.exec(); } @@ -134,9 +134,11 @@ bool QWinRTMessageDialogHelper::show(Qt::WindowFlags windowFlags, Qt::WindowModa RETURN_FALSE_IF_FAILED("Failed to create command factory"); ComPtr<IMessageDialog> dialog; - HStringReference nativeText(reinterpret_cast<LPCWSTR>(text.utf16()), text.size()); + HStringReference nativeText(reinterpret_cast<LPCWSTR>(text.utf16()), + uint(text.size())); if (!title.isEmpty()) { - HStringReference nativeTitle(reinterpret_cast<LPCWSTR>(title.utf16()), title.size()); + HStringReference nativeTitle(reinterpret_cast<LPCWSTR>(title.utf16()), + uint(title.size())); hr = dialogFactory->CreateWithTitle(nativeText.Get(), nativeTitle.Get(), &dialog); RETURN_FALSE_IF_FAILED("Failed to create dialog with title"); } else { @@ -162,7 +164,8 @@ bool QWinRTMessageDialogHelper::show(Qt::WindowFlags windowFlags, Qt::WindowModa continue; // Add native command const QString label = d->theme->standardButtonText(i); - HStringReference nativeLabel(reinterpret_cast<LPCWSTR>(label.utf16()), label.size()); + HStringReference nativeLabel(reinterpret_cast<LPCWSTR>(label.utf16()), + uint(label.size())); ComPtr<IUICommand> command; hr = commandFactory->Create(nativeLabel.Get(), &command); RETURN_HR_IF_FAILED("Failed to create message box command"); |