diff options
author | Oliver Wolff <oliver.wolff@qt.io> | 2018-09-05 14:48:30 +0200 |
---|---|---|
committer | Oliver Wolff <oliver.wolff@qt.io> | 2018-09-26 05:41:05 +0000 |
commit | 7421a0e88208a9afe0ab360a0646bf81a84d2290 (patch) | |
tree | 0a518e15e1d4095d7710ec919b7d772bb66411b3 /src/plugins/platforms/winrt/qwinrtservices.cpp | |
parent | e5b4e7a9ed5b1d65b2ea6870498d7a1a4dbb3237 (diff) |
winrt platform plugin: Fix clang warnings
Fixed warnings:
- missing override specifier
- 0 as nullptr constant
- implicit change of signedness
- non portable path to header file
Change-Id: I6977bc561176ac7804ac01325b84c15ba849bbf2
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
Reviewed-by: Andre de la Rocha <andre.rocha@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'src/plugins/platforms/winrt/qwinrtservices.cpp')
-rw-r--r-- | src/plugins/platforms/winrt/qwinrtservices.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/plugins/platforms/winrt/qwinrtservices.cpp b/src/plugins/platforms/winrt/qwinrtservices.cpp index 05620ca4c8..b27c408f40 100644 --- a/src/plugins/platforms/winrt/qwinrtservices.cpp +++ b/src/plugins/platforms/winrt/qwinrtservices.cpp @@ -83,17 +83,14 @@ QWinRTServices::QWinRTServices() Q_ASSERT_X(SUCCEEDED(hr), Q_FUNC_INFO, qPrintable(qt_error_string(hr))); } -QWinRTServices::~QWinRTServices() -{ -} - bool QWinRTServices::openUrl(const QUrl &url) { Q_D(QWinRTServices); ComPtr<IUriRuntimeClass> uri; QString urlString = url.toString(); - HStringReference uriString(reinterpret_cast<LPCWSTR>(urlString.utf16()), urlString.length()); + HStringReference uriString(reinterpret_cast<LPCWSTR>(urlString.utf16()), + uint(urlString.length())); HRESULT hr = d->uriFactory->CreateUri(uriString.Get(), &uri); RETURN_FALSE_IF_FAILED("Failed to create URI from QUrl."); @@ -122,7 +119,8 @@ bool QWinRTServices::openDocument(const QUrl &url) } if (!file) { const QString pathString = QDir::toNativeSeparators(url.toLocalFile()); - HStringReference path(reinterpret_cast<LPCWSTR>(pathString.utf16()), pathString.length()); + HStringReference path(reinterpret_cast<LPCWSTR>(pathString.utf16()), + uint(pathString.length())); ComPtr<IAsyncOperation<StorageFile *>> op; hr = d->fileFactory->GetFileFromPathAsync(path.Get(), &op); RETURN_FALSE_IF_FAILED("Failed to initialize file URI."); |