diff options
| author | Gatis Paeglis <gatis.paeglis@qt.io> | 2018-08-31 13:03:47 +0200 |
|---|---|---|
| committer | Gatis Paeglis <gatis.paeglis@qt.io> | 2018-10-14 18:38:24 +0000 |
| commit | 243c3044b647357ca6df79ac1497ae43de957d31 (patch) | |
| tree | 44c03794457a49a36cbfabd3e0b83733f879ddd7 /src/plugins/platforms/xcb/xcb_qpa_lib.pro | |
| parent | a880780ff962dc31be24b508f811c1a2fd0b0f36 (diff) | |
xcb: lock-free event processing
For details how this works refer to the documentation in the patch.
The follow-up patches will switch to calling processXcbEvents() on every
event loop iteration. With the existing code that would mean frequent
locking of shared data (event queue). Acquiring a lock is fast, but
lock contention isn't. To avoid potential problems, reimplement xcb event
processing to be lock-free. Besides theoretical performance benefits,
this definitally improves code readability in qxcbconnection.cpp. Thanks
to Mikhail Svetkin for questioning the design of the existing code.
Done-with: Mikhail Svetkin <mikhail.svetkin@qt.io>
Change-Id: I935f2b6ca802580f5c80205aef7b2f9afc172d26
Reviewed-by: Mikhail Svetkin <mikhail.svetkin@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/plugins/platforms/xcb/xcb_qpa_lib.pro')
| -rw-r--r-- | src/plugins/platforms/xcb/xcb_qpa_lib.pro | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/plugins/platforms/xcb/xcb_qpa_lib.pro b/src/plugins/platforms/xcb/xcb_qpa_lib.pro index 9390d04983..fbda8c39b9 100644 --- a/src/plugins/platforms/xcb/xcb_qpa_lib.pro +++ b/src/plugins/platforms/xcb/xcb_qpa_lib.pro @@ -27,7 +27,8 @@ SOURCES = \ qxcbcursor.cpp \ qxcbimage.cpp \ qxcbxsettings.cpp \ - qxcbsystemtraytracker.cpp + qxcbsystemtraytracker.cpp \ + qxcbeventqueue.cpp HEADERS = \ qxcbclipboard.h \ @@ -45,7 +46,8 @@ HEADERS = \ qxcbimage.h \ qxcbxsettings.h \ qxcbsystemtraytracker.h \ - qxcbxkbcommon.h + qxcbxkbcommon.h \ + qxcbeventqueue.h qtConfig(draganddrop) { SOURCES += qxcbdrag.cpp |