diff options
author | Lars Knoll <lars.knoll@qt.io> | 2020-09-10 19:51:38 +0200 |
---|---|---|
committer | Lars Knoll <lars.knoll@qt.io> | 2020-09-21 14:56:09 +0200 |
commit | 848927b688d4709d0b71590518e2c32fe7866147 (patch) | |
tree | 67c7db42436563299ab8fc713dbc91ce31eaf508 /src/plugins/platforms/xcb | |
parent | cf015cd08bc7a977b6bacac3575952a77e0c0cad (diff) |
Cleanup API of QMimeData
Do not use QVariant::Type anymore, instead use QMetaType
For some reason, this pushed the qvariant autotest over the limit where
MSVC requires the /bigobj flag, so add that one.
[ChangeLog][QtCore][QMimeData] The signature of the virtual retrieveData()
function has changed and now takes a QMetaType instead of a QVariant::Type.
Change-Id: Ib46773bd731ee2177b1ef74d8162d744be7017ef
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/plugins/platforms/xcb')
-rw-r--r-- | src/plugins/platforms/xcb/qxcbclipboard.cpp | 4 | ||||
-rw-r--r-- | src/plugins/platforms/xcb/qxcbdrag.cpp | 10 | ||||
-rw-r--r-- | src/plugins/platforms/xcb/qxcbmime.cpp | 8 | ||||
-rw-r--r-- | src/plugins/platforms/xcb/qxcbmime.h | 4 |
4 files changed, 13 insertions, 13 deletions
diff --git a/src/plugins/platforms/xcb/qxcbclipboard.cpp b/src/plugins/platforms/xcb/qxcbclipboard.cpp index 6d023035f2..56fe1a5b45 100644 --- a/src/plugins/platforms/xcb/qxcbclipboard.cpp +++ b/src/plugins/platforms/xcb/qxcbclipboard.cpp @@ -123,9 +123,9 @@ protected: return list.contains(format); } - QVariant retrieveData_sys(const QString &fmt, QVariant::Type type) const override + QVariant retrieveData_sys(const QString &fmt, QMetaType type) const override { - auto requestedType = QMetaType::Type(type); + auto requestedType = type; if (fmt.isEmpty() || isEmpty()) return QByteArray(); diff --git a/src/plugins/platforms/xcb/qxcbdrag.cpp b/src/plugins/platforms/xcb/qxcbdrag.cpp index 774a5689c7..401863790c 100644 --- a/src/plugins/platforms/xcb/qxcbdrag.cpp +++ b/src/plugins/platforms/xcb/qxcbdrag.cpp @@ -112,9 +112,9 @@ public: protected: bool hasFormat_sys(const QString &mimeType) const override; QStringList formats_sys() const override; - QVariant retrieveData_sys(const QString &mimeType, QVariant::Type type) const override; + QVariant retrieveData_sys(const QString &mimeType, QMetaType type) const override; - QVariant xdndObtainData(const QByteArray &format, QMetaType::Type requestedType) const; + QVariant xdndObtainData(const QByteArray &format, QMetaType requestedType) const; QXcbDrag *drag; }; @@ -1342,14 +1342,14 @@ QXcbDropData::~QXcbDropData() { } -QVariant QXcbDropData::retrieveData_sys(const QString &mimetype, QVariant::Type requestedType) const +QVariant QXcbDropData::retrieveData_sys(const QString &mimetype, QMetaType requestedType) const { QByteArray mime = mimetype.toLatin1(); - QVariant data = xdndObtainData(mime, QMetaType::Type(requestedType)); + QVariant data = xdndObtainData(mime, requestedType); return data; } -QVariant QXcbDropData::xdndObtainData(const QByteArray &format, QMetaType::Type requestedType) const +QVariant QXcbDropData::xdndObtainData(const QByteArray &format, QMetaType requestedType) const { QByteArray result; diff --git a/src/plugins/platforms/xcb/qxcbmime.cpp b/src/plugins/platforms/xcb/qxcbmime.cpp index bb168b9b00..738d0e3b91 100644 --- a/src/plugins/platforms/xcb/qxcbmime.cpp +++ b/src/plugins/platforms/xcb/qxcbmime.cpp @@ -158,14 +158,14 @@ QList<xcb_atom_t> QXcbMime::mimeAtomsForFormat(QXcbConnection *connection, const } QVariant QXcbMime::mimeConvertToFormat(QXcbConnection *connection, xcb_atom_t a, const QByteArray &d, const QString &format, - QMetaType::Type requestedType, bool hasUtf8) + QMetaType requestedType, bool hasUtf8) { QByteArray data = d; QString atomName = mimeAtomToString(connection, a); // qDebug() << "mimeConvertDataToFormat" << format << atomName << data; if (hasUtf8 && atomName == format + QLatin1String(";charset=utf-8")) { - if (requestedType == QMetaType::QString) + if (requestedType.id() == QMetaType::QString) return QString::fromUtf8(data); return data; } @@ -255,7 +255,7 @@ QVariant QXcbMime::mimeConvertToFormat(QXcbConnection *connection, xcb_atom_t a, return QVariant(); } -xcb_atom_t QXcbMime::mimeAtomForFormat(QXcbConnection *connection, const QString &format, QMetaType::Type requestedType, +xcb_atom_t QXcbMime::mimeAtomForFormat(QXcbConnection *connection, const QString &format, QMetaType requestedType, const QList<xcb_atom_t> &atoms, bool *hasUtf8) { *hasUtf8 = false; @@ -288,7 +288,7 @@ xcb_atom_t QXcbMime::mimeAtomForFormat(QXcbConnection *connection, const QString // for string/text requests try to use a format with a well-defined charset // first to avoid encoding problems - if (requestedType == QMetaType::QString + if (requestedType.id() == QMetaType::QString && format.startsWith(QLatin1String("text/")) && !format.contains(QLatin1String("charset="))) { diff --git a/src/plugins/platforms/xcb/qxcbmime.h b/src/plugins/platforms/xcb/qxcbmime.h index d348bae77e..fe9b2249c9 100644 --- a/src/plugins/platforms/xcb/qxcbmime.h +++ b/src/plugins/platforms/xcb/qxcbmime.h @@ -60,8 +60,8 @@ public: static bool mimeDataForAtom(QXcbConnection *connection, xcb_atom_t a, QMimeData *mimeData, QByteArray *data, xcb_atom_t *atomFormat, int *dataFormat); static QVariant mimeConvertToFormat(QXcbConnection *connection, xcb_atom_t a, const QByteArray &data, const QString &format, - QMetaType::Type requestedType, bool hasUtf8); - static xcb_atom_t mimeAtomForFormat(QXcbConnection *connection, const QString &format, QMetaType::Type requestedType, + QMetaType requestedType, bool hasUtf8); + static xcb_atom_t mimeAtomForFormat(QXcbConnection *connection, const QString &format, QMetaType requestedType, const QList<xcb_atom_t> &atoms, bool *hasUtf8); }; |