macOS: Don't re-send key event through input method on focus object change

In 0c2ca26cd9583092f3ade7b18bc2423336a6202b we started re-sending the
key event through the input method when we detected a focus object change,
to support the use-case of QAbstractItemView opening an editor and changing
focus in response to the first QEvent::InputMethod event.

Unfortunately this doesn't work as a general approach, because we don't
know what the reason was for the change in focus object. For example,
a client might respond to a Qt::Key_Return press by changing the focus
to the next input element, and re-sending the key event would in that
case insert a new-line in the new focus object -- counter to the
expectations of the client.

Since we can't know the reason for the changed focus object we can't
assume re-sending the key event is safe.

Task-number: QTBUG-54848
Fixes: QTBUG-96726
Pick-to: 6.2 6.2.0
Change-Id: Iea8b166385925cd1a05ef62d5cf763638d9f8a67
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>

1 files changed, 0 insertions, 9 deletions

diff --git a/src/plugins/platforms/cocoa/qnsview_keys.mm b/src/plugins/platforms/cocoa/qnsview_keys.mm
index 5e99d0a9c3..d6e0c4b012 100644
--- a/src/plugins/platforms/cocoa/qnsview_keys.mm
+++ b/src/plugins/platforms/cocoa/qnsview_keys.mm
@@ -98,15 +98,6 @@
                     qCDebug(lcQpaKeys) << "Interpreting key event for focus object" << focusObject;
                     m_currentlyInterpretedKeyEvent = nsevent;
                     [self interpretKeyEvents:@[nsevent]];
-
-                    // If the receiver opens an editor in response to a key press, then the focus will change, the input
-                    // method will be reset, and the first key press will be gone. If the focus object changes, then we
-                    // need to pass the key event to the input method once more.
-                    if (qApp->focusObject() != focusObject) {
-                        qCDebug(lcQpaKeys) << "Interpreting key event again for new focus object" << qApp->focusObject();
-                        [self interpretKeyEvents:@[nsevent]];
-                    }
-
                     m_currentlyInterpretedKeyEvent = 0;
 
                     // If the last key we sent was dead, then pass the next