diff options
| author | Timur Pocheptsov <timur.pocheptsov@qt.io> | 2023-01-31 14:54:34 +0100 |
|---|---|---|
| committer | Mårten Nordheim <marten.nordheim@qt.io> | 2023-02-01 06:00:13 +0000 |
| commit | 0ca8c50d95995287fdd46e3668b994f9af638f50 (patch) | |
| tree | 9d242117ffa8899f11d436a03a967c6a68a9f49e /src/plugins/tls/openssl/qdtls_openssl.cpp | |
| parent | 5c9f044ac0757200adcb36702ef8ff2d594cba79 (diff) | |
DTLS cookie: use CRYPTO_memcmp instead of std::memcmp
memcmp and openssl callbacks are somewhat of a red flag, so use
CRYPTO_memcmp for the sake of looks.
Done-with: Maximilian Blochberger
Change-Id: I38d038ed96830cfd54c6f5cd684f80bee8d42899
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/plugins/tls/openssl/qdtls_openssl.cpp')
| -rw-r--r-- | src/plugins/tls/openssl/qdtls_openssl.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/tls/openssl/qdtls_openssl.cpp b/src/plugins/tls/openssl/qdtls_openssl.cpp index 9531d5b6aa..cf0b42a82f 100644 --- a/src/plugins/tls/openssl/qdtls_openssl.cpp +++ b/src/plugins/tls/openssl/qdtls_openssl.cpp @@ -205,7 +205,7 @@ extern "C" int q_verify_cookie_callback(SSL *ssl, const unsigned char *cookie, return 0; return newCookieLength == cookieLength - && !std::memcmp(cookie, newCookie, cookieLength); + && !q_CRYPTO_memcmp(cookie, newCookie, size_t(cookieLength)); } extern "C" int q_X509DtlsCallback(int ok, X509_STORE_CTX *ctx) |