diff options
| author | Oswald Buddenhagen <oswald.buddenhagen@digia.com> | 2013-04-19 18:11:05 +0200 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-05-20 15:20:26 +0200 |
| commit | 85e61297f7b02297641826332dbdbc845a88c34b (patch) | |
| tree | db3d836309af897f70672adbfc4a118ff70321ff /src/printsupport/doc/src | |
| parent | c30a7ecce1a236514599825cc818323d8affd9dc (diff) | |
restore QProcessEnvironment shared data thread safety on unix
implicit sharing together with 'mutable' is a time bomb.
we need to protect the nameMap, because concurrent "reads" may try to
insert into the hash, which would go boom.
we need to protect the key/value of Hash objects, because while the
refcounting is atomic, the d pointer assignments are not, which would
also go boom.
we can simply use a QMutex to protect the whole environment, because it
is very cheap in the uncontended case.
Task-number: QTBUG-30779
Change-Id: Iaad5720041ca06691d75eb9c6c0e1c120d4a7b46
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Diffstat (limited to 'src/printsupport/doc/src')
0 files changed, 0 insertions, 0 deletions