path: root/src/printsupport/kernel/qprintdevice_p.h
diff options
authorFriedemann Kleint <>2015-04-22 13:50:21 +0200
committerFriedemann Kleint <>2015-05-05 14:06:27 +0000
commita6bcdf151647ab7a97c9fe1d2c8c8dd2b718244e (patch)
treec9d2194926ea28e83a18c61ebab3b3d1e75e8932 /src/printsupport/kernel/qprintdevice_p.h
parent7c6b6876aa8841a56a6571c6a039c67a5d649bdb (diff)
Clean up API of QPlatformPrintDevice (QPA).
The class inherited QSharedData, had a non-virtual clone() function and a non-virtual operator==() which compared QPlatformPrintDevice::id(). Derived classes implemented clone() and operator==() comparing ids to no effect. The class does not have any setters modifying its values, so detaching, copying and assigning does not make sense. Remove the inheritance, clone(), and operator==() and make the class a non-copyable base class. Use a QSharedPointer instead of a QSharedDataPointer to store it in QPrintDevice. Remove copy constructors and clone() reimplementations that were never called in implementations. Found while investigating QTBUG-44991. Task-number: QTBUG-44991 Change-Id: Ib79354b37048d04d50d936f1d0ae06c36efaac00 Reviewed-by: Morten Johan Sørvig <> Reviewed-by: Paul Olav Tvete <>
Diffstat (limited to 'src/printsupport/kernel/qprintdevice_p.h')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/printsupport/kernel/qprintdevice_p.h b/src/printsupport/kernel/qprintdevice_p.h
index ad55cded0e..ddf5595734 100644
--- a/src/printsupport/kernel/qprintdevice_p.h
+++ b/src/printsupport/kernel/qprintdevice_p.h
@@ -136,7 +136,7 @@ private:
friend class QPlatformPrinterSupport;
friend class QPlatformPrintDevice;
QPrintDevice(QPlatformPrintDevice *dd);
- QSharedDataPointer<QPlatformPrintDevice> d;
+ QSharedPointer<QPlatformPrintDevice> d;