diff options
author | Mark Brand <mabrand@mabrand.nl> | 2012-03-19 09:21:55 +0100 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-03-22 16:13:21 +0100 |
commit | f44360923e37f967fa01163b5ddbb6f5c0de8ddb (patch) | |
tree | 517d8c47e0caca67504cd013ff2ce034ca932e1a /src/sql/models/qsqltablemodel.cpp | |
parent | c7b9a60571ace1a555226c33a2dd5afbe6bfbcf4 (diff) |
QSqlTM/QSqlRTM: improve style and readability
General changes:
const, scope, braces, hash[] for clarity, comment wording and
spelling.
QSqlRelationalTableModel::selectStatement() readability:
Renamed private method.
QVector<Class>.value() already defaults to null object value, so there
is no point in handling this case explicitly.
Alias rec for d->rec added more noise than clarity.
Using "tables" list only adds an extra step. Simple concatenation does
the trick.
Deduplicate code for building table expression and JOIN condition.
Change-Id: Ia52afaf3c3937a26595d5ae867982664002562d8
Reviewed-by: Honglei Zhang <honglei.zhang@nokia.com>
Diffstat (limited to 'src/sql/models/qsqltablemodel.cpp')
-rw-r--r-- | src/sql/models/qsqltablemodel.cpp | 38 |
1 files changed, 16 insertions, 22 deletions
diff --git a/src/sql/models/qsqltablemodel.cpp b/src/sql/models/qsqltablemodel.cpp index d8d691fa0c..0e5eba1a73 100644 --- a/src/sql/models/qsqltablemodel.cpp +++ b/src/sql/models/qsqltablemodel.cpp @@ -84,12 +84,9 @@ int QSqlTableModelPrivate::insertCount(int maxRow) const int cnt = 0; CacheMap::ConstIterator i = cache.constBegin(); const CacheMap::ConstIterator e = cache.constEnd(); - for (; - i != e && (maxRow < 0 || i.key() <= maxRow); - ++i) { + for ( ; i != e && (maxRow < 0 || i.key() <= maxRow); ++i) if (i.value().insert()) ++cnt; - } return cnt; } @@ -175,14 +172,12 @@ bool QSqlTableModelPrivate::exec(const QString &stmt, bool prepStatement, } } int i; - for (i = 0; i < rec.count(); ++i) { + for (i = 0; i < rec.count(); ++i) if (rec.isGenerated(i)) editQuery.addBindValue(rec.value(i)); - } - for (i = 0; i < whereValues.count(); ++i) { + for (i = 0; i < whereValues.count(); ++i) if (whereValues.isGenerated(i) && !whereValues.isNull(i)) editQuery.addBindValue(whereValues.value(i)); - } if (!editQuery.exec()) { error = editQuery.lastError(); @@ -363,7 +358,7 @@ QString QSqlTableModel::tableName() const bool QSqlTableModel::select() { Q_D(QSqlTableModel); - QString query = selectStatement(); + const QString query = selectStatement(); if (query.isEmpty()) return false; @@ -593,11 +588,11 @@ bool QSqlTableModel::updateRowInTable(int row, const QSqlRecord &values) emit beforeUpdate(row, rec); const QSqlRecord whereValues = d->primaryValues(row); - bool prepStatement = d->db.driver()->hasFeature(QSqlDriver::PreparedQueries); + const bool prepStatement = d->db.driver()->hasFeature(QSqlDriver::PreparedQueries); QString stmt = d->db.driver()->sqlStatement(QSqlDriver::UpdateStatement, d->tableName, rec, prepStatement); - QString where = d->db.driver()->sqlStatement(QSqlDriver::WhereStatement, d->tableName, - whereValues, prepStatement); + const QString where = d->db.driver()->sqlStatement(QSqlDriver::WhereStatement, d->tableName, + whereValues, prepStatement); if (stmt.isEmpty() || where.isEmpty() || row < 0 || row >= rowCount()) { d->error = QSqlError(QLatin1String("No Fields to update"), QString(), @@ -629,9 +624,9 @@ bool QSqlTableModel::insertRowIntoTable(const QSqlRecord &values) QSqlRecord rec = values; emit beforeInsert(rec); - bool prepStatement = d->db.driver()->hasFeature(QSqlDriver::PreparedQueries); - QString stmt = d->db.driver()->sqlStatement(QSqlDriver::InsertStatement, d->tableName, - rec, prepStatement); + const bool prepStatement = d->db.driver()->hasFeature(QSqlDriver::PreparedQueries); + const QString stmt = d->db.driver()->sqlStatement(QSqlDriver::InsertStatement, d->tableName, + rec, prepStatement); if (stmt.isEmpty()) { d->error = QSqlError(QLatin1String("No Fields to update"), QString(), @@ -660,15 +655,15 @@ bool QSqlTableModel::deleteRowFromTable(int row) emit beforeDelete(row); const QSqlRecord whereValues = d->primaryValues(row); - bool prepStatement = d->db.driver()->hasFeature(QSqlDriver::PreparedQueries); + const bool prepStatement = d->db.driver()->hasFeature(QSqlDriver::PreparedQueries); QString stmt = d->db.driver()->sqlStatement(QSqlDriver::DeleteStatement, d->tableName, QSqlRecord(), prepStatement); - QString where = d->db.driver()->sqlStatement(QSqlDriver::WhereStatement, - d->tableName, - whereValues, - prepStatement); + const QString where = d->db.driver()->sqlStatement(QSqlDriver::WhereStatement, + d->tableName, + whereValues, + prepStatement); if (stmt.isEmpty() || where.isEmpty()) { d->error = QSqlError(QLatin1String("Unable to delete row"), QString(), @@ -838,9 +833,8 @@ void QSqlTableModel::revertAll() Q_D(QSqlTableModel); const QList<int> rows(d->cache.keys()); - for (int i = rows.size() - 1; i >= 0; --i) { + for (int i = rows.size() - 1; i >= 0; --i) revertRow(rows.value(i)); - } } /*! |