diff options
author | David Faure <faure@kde.org> | 2012-06-23 21:48:53 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-07-20 18:34:08 +0200 |
commit | 1603ba23656c8c31dc05fe9b3f1e12b22e29989a (patch) | |
tree | 5e507db7a34023b9236c982257923a2242c1693a /src/testlib/qbenchmarkevent_p.h | |
parent | 981ea7a1aa602cebfdd43b7dc6efd3abf5a1cba3 (diff) |
Provide public API for native event filtering, moved up from QPA.
The previous API was hard to use (global function, no type safety,
manual chaining), and confusing (app vs dispatcher split only made
sense on Windows). Installing and removing out of order would have
the risk of setting back a dangling pointer (crash). Meanwhile QPA
added type safety, and this new API models the QObject::installEventFilter
API for ease of use. The virtual method is in a new interface,
QAbstractNativeEventFilter.
QPA was even calling the dispatcher event filter with QPA-private event
classes, which made no sense (refactoring leftover from when the code
was in the dispatcher). Now the QPA plugins trigger the qcoreapp event
filters with the actual native events directly.
Change-Id: Ie35e47c59c862383bcaf857b28d54f7c72547882
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
Diffstat (limited to 'src/testlib/qbenchmarkevent_p.h')
-rw-r--r-- | src/testlib/qbenchmarkevent_p.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/testlib/qbenchmarkevent_p.h b/src/testlib/qbenchmarkevent_p.h index c4d98bf8a1..938ce13f3c 100644 --- a/src/testlib/qbenchmarkevent_p.h +++ b/src/testlib/qbenchmarkevent_p.h @@ -56,12 +56,14 @@ #include <QtTest/private/qbenchmarkmeasurement_p.h> #include <QAbstractEventDispatcher> #include <QObject> +#include <QAbstractNativeEventFilter> QT_BEGIN_NAMESPACE -class QBenchmarkEvent : public QBenchmarkMeasurerBase +class QBenchmarkEvent : public QBenchmarkMeasurerBase, public QAbstractNativeEventFilter { public: + QBenchmarkEvent(); ~QBenchmarkEvent(); void start(); qint64 checkpoint(); @@ -71,8 +73,8 @@ public: int adjustMedianCount(int suggestion); bool repeatCount() { return 1; } QTest::QBenchmarkMetric metricType(); - static bool eventCountingMechanism(void *message); - static qint64 eventCounter; + virtual bool nativeEventFilter(const QByteArray &eventType, void *message, long *result); + qint64 eventCounter; }; QT_END_NAMESPACE |