summaryrefslogtreecommitdiffstats
path: root/src/testlib
diff options
context:
space:
mode:
authorJason McDonald <jason.mcdonald@nokia.com>2011-12-16 14:01:12 +1000
committerQt by Nokia <qt-info@nokia.com>2011-12-19 04:43:38 +0100
commite299832dbf3e2227200e7317805f7773d60fcbba (patch)
tree9f9d5c5ec0b7f18c5b93b6d504b8c5df03b00a11 /src/testlib
parentf1f500b9aa70edfc7511a714c9aefb132d66f10e (diff)
Avoid confusing method overloading in QTestTable.
The private class had two append() methods, one appending a column and one appending a row. Use more meaningful names instead of overloading orthogonal operations. Change-Id: I97e0268d6cb289694557846f244fe770cf980aaf Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Diffstat (limited to 'src/testlib')
-rw-r--r--src/testlib/qtesttable.cpp12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/testlib/qtesttable.cpp b/src/testlib/qtesttable.cpp
index 0c76076b88..bc8bc3e13c 100644
--- a/src/testlib/qtesttable.cpp
+++ b/src/testlib/qtesttable.cpp
@@ -73,8 +73,8 @@ public:
ElementList *list;
DataList *dataList;
- void append(int elemType, const char *elemName);
- void append(QTestData *data);
+ void addColumn(int elemType, const char *elemName);
+ void addRow(QTestData *data);
ElementList *elementAt(int index);
QTestData *dataAt(int index);
@@ -124,7 +124,7 @@ QTestTablePrivate::~QTestTablePrivate()
}
}
-void QTestTablePrivate::append(int elemType, const char *elemName)
+void QTestTablePrivate::addColumn(int elemType, const char *elemName)
{
ElementList *item = new ElementList;
item->elementName = elemName;
@@ -139,7 +139,7 @@ void QTestTablePrivate::append(int elemType, const char *elemName)
last->next = item;
}
-void QTestTablePrivate::append(QTestData *data)
+void QTestTablePrivate::addRow(QTestData *data)
{
DataList *item = new DataList;
item->data = data;
@@ -158,7 +158,7 @@ void QTestTable::addColumn(int type, const char *name)
QTEST_ASSERT(type);
QTEST_ASSERT(name);
- d->append(type, name);
+ d->addColumn(type, name);
}
int QTestTable::elementCount() const
@@ -192,7 +192,7 @@ bool QTestTable::isEmpty() const
QTestData *QTestTable::newData(const char *tag)
{
QTestData *dt = new QTestData(tag, this);
- d->append(dt);
+ d->addRow(dt);
return dt;
}