diff options
| author | Konstantin Ritt <ritt.ks@gmail.com> | 2015-01-23 13:05:12 +0400 |
|---|---|---|
| committer | Konstantin Ritt <ritt.ks@gmail.com> | 2015-02-13 16:29:16 +0000 |
| commit | 9b67d89c24666d405dd00e63bb56c924738aa002 (patch) | |
| tree | bf0c0197b68097e9aace8ac3708dcbf0e3fe0c7c /src/tools/qdoc/htmlgenerator.cpp | |
| parent | 22b5c39e8e0f4d8cb8a2b2d661e0451e01b75929 (diff) | |
Pass params of shareable type by const-ref rather than by value
...where passing them by value was not intentional.
Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/tools/qdoc/htmlgenerator.cpp')
| -rw-r--r-- | src/tools/qdoc/htmlgenerator.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/tools/qdoc/htmlgenerator.cpp b/src/tools/qdoc/htmlgenerator.cpp index d422356822..f4ada7132f 100644 --- a/src/tools/qdoc/htmlgenerator.cpp +++ b/src/tools/qdoc/htmlgenerator.cpp @@ -3190,7 +3190,7 @@ void HtmlGenerator::generateList(const Node* relative, CodeMarker* marker, const #if 0 QStringList keys = groups.uniqueKeys(); - foreach (QString key, keys) { + foreach (const QString &key, keys) { GroupNode* gn = static_cast<GroupNode*>(groups.value(key)); if (gn) { out() << QString("<h3><a href=\"%1\">%2</a></h3>\n").arg( @@ -3217,7 +3217,7 @@ void HtmlGenerator::generateList(const Node* relative, CodeMarker* marker, const out() << "<ul>\n"; QStringList titles = nm.keys(); - foreach (QString t, titles) { + foreach (const QString &t, titles) { Node* member = nm.value(t); QString title = member->fullTitle(); if (title.startsWith("The ")) @@ -4484,7 +4484,7 @@ void HtmlGenerator::generateManifestFiles() for each manifest file to be generated. \a manifest is the type of manifest file. */ -void HtmlGenerator::generateManifestFile(QString manifest, QString element) +void HtmlGenerator::generateManifestFile(const QString &manifest, const QString &element) { ExampleNodeMap& exampleNodeMap = qdb_->exampleNodeMap(); if (exampleNodeMap.isEmpty()) |