diff options
author | Marc Mutz <marc.mutz@kdab.com> | 2019-06-18 08:56:16 +0200 |
---|---|---|
committer | Marc Mutz <marc.mutz@kdab.com> | 2019-07-02 12:05:22 +0200 |
commit | 5342805920064dfe64c23690cd1d895a95478154 (patch) | |
tree | 3ce7476d659e99ade3340ff93a0f0df06f583e73 /src/tools/qlalr/lalr.cpp | |
parent | d5f65d8814e85611f8eff85c6a7d64813c08206d (diff) |
QCoreWlanEngine: port away from Java-style iterators (and other fixes)
The main goal of this patch was to port away from Java-style
iterators, to make QtBase QT_NO_JAVA_STYLE_ITERATORS-clean. And this
the patch achieves.
But I couldn't resist a few drive-by fixes, too, to wit:
- Use qDeleteAll() instead of while(!isEmpty()) delete takeFirst()
- Use QMap::last() instead of iterating to the end, remembering the
last-seen value
- Use QMap::contains() instead of QMap::keys().contains()
- Use qExchange() instead of copy+clear
- Make some functions const (requires the mutex member to be marked as
mutable, which is common for mutex members)
I am almost certain that getSsidFromNetworkName() cannot work correctly.
But this patch does not attempt to change the algorithm.
Change-Id: Ifa04d7837bdc0837036c3a7a73f8c51f4e681f42
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
Diffstat (limited to 'src/tools/qlalr/lalr.cpp')
0 files changed, 0 insertions, 0 deletions