Use const-ref in foreach if T is big or non-trivial

Criteria: Linux x86_64, sizeof(T) > 8

Change-Id: I78c2b776ff219fa1ff6632fde17ae25fae66c54e
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/src/tools/qlalr/lalr.cpp b/src/tools/qlalr/lalr.cpp
index 3d0d5de19b..4470c8f07f 100644
--- a/src/tools/qlalr/lalr.cpp
+++ b/src/tools/qlalr/lalr.cpp
@@ -367,7 +367,7 @@ void Automaton::closure (StatePointer state)
 
       if (_M_grammar->isNonTerminal (*item->dot))
         {
-          foreach (RulePointer rule, _M_grammar->rule_map.values (*item->dot))
+          foreach (const RulePointer &rule, _M_grammar->rule_map.values (*item->dot))
             {
               Item ii;
               ii.rule = rule;
@@ -413,7 +413,7 @@ void Automaton::buildLookbackSets ()
           if (! _M_grammar->isNonTerminal (A))
             continue;
 
-          foreach (RulePointer rule, _M_grammar->rule_map.values (A))
+          foreach (const RulePointer &rule, _M_grammar->rule_map.values (A))
             {
               StatePointer q = p;
 
@@ -606,7 +606,7 @@ void Automaton::buildIncludesDigraph ()
           if (! _M_grammar->isNonTerminal (name))
             continue;
 
-          foreach (RulePointer rule, _M_grammar->rule_map.values (name))
+          foreach (const RulePointer &rule, _M_grammar->rule_map.values (name))
             {
               StatePointer p = pp;
 
@@ -706,7 +706,7 @@ void Automaton::buildLookaheads ()
     {
       for (ItemPointer item = p->closure.begin (); item != p->closure.end (); ++item)
         {
-          foreach (Lookback lookback, lookbacks.values (item))
+          foreach (const Lookback &lookback, lookbacks.values (item))
             {
               StatePointer q = lookback.state;