diff options
author | Edward Welbourne <edward.welbourne@qt.io> | 2016-10-06 18:47:38 +0200 |
---|---|---|
committer | Edward Welbourne <edward.welbourne@qt.io> | 2017-07-31 09:25:13 +0000 |
commit | 3d195c41e53847f7ec74a93f79e7a64d3581f8a8 (patch) | |
tree | a96b4575ffd53f56854ef23f5e668ab0beabc268 /src/tools/qlalr/qlalr.pro | |
parent | 60a9747bb50934979ba66a3eeab6e5295fa2e492 (diff) |
QTzTimeZonePrivate: resolve a misguided TODO
A three-way if/else-if/else had the same line of code as all three
branches and a TODO to fix that. As it happens, the flags being
tested here are irrelevant; they indicate whether the transition time
(which is always given in UTC) was *specified* (i.e. the how a
relevant authority identified the transition time) in terms of local
wall-clock time, local standard time or UTC. The correction
contemplated by TODO (and experimented with in an earlier version of
this change, that broke correct tests) has in fact been done for us by
the zoneinfo package's zic (zone-info compiler) in the course of
writing the binary file we're parsing. These flags are only present
in the binary file to enable the date command to correctly handle
POSIX-style values for the TZ environment variable.
We consequently have no need for the tz_ttisgmt or tz_ttisstd fields
of our QTzType and can save the bother of recording them, when reading
their part of the file.
Change-Id: Ia33e87291ecc383eb5cb796d7b8a5213a94f1648
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/tools/qlalr/qlalr.pro')
0 files changed, 0 insertions, 0 deletions