Get rid of QRegExp usage in rcc

As a drive-by, enable testing of rcc in the cmake build.

Change-Id: I4150ff3ffe7404bab0cbc72f80b23b47a60cf33d
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch>

1 files changed, 11 insertions, 2 deletions

diff --git a/src/tools/rcc/rcc.cpp b/src/tools/rcc/rcc.cpp
index 808208573a..8b1ebad14c 100644
--- a/src/tools/rcc/rcc.cpp
+++ b/src/tools/rcc/rcc.cpp
@@ -37,7 +37,6 @@
 #include <qfile.h>
 #include <qiodevice.h>
 #include <qlocale.h>
-#include <qregexp.h>
 #include <qstack.h>
 #include <qxmlstream.h>
 
@@ -1362,7 +1361,17 @@ bool RCCResourceLibrary::writeInitializer()
         QString initNameStr = m_initName;
         if (!initNameStr.isEmpty()) {
             initNameStr.prepend(QLatin1Char('_'));
-            initNameStr.replace(QRegExp(QLatin1String("[^a-zA-Z0-9_]")), QLatin1String("_"));
+            auto isAsciiLetterOrNumber = [] (QChar c) -> bool {
+                ushort ch = c.unicode();
+                return (ch >= '0' && ch <= '9') ||
+                        (ch >= 'A' && ch <= 'Z') ||
+                        (ch >= 'a' && ch <= 'z') ||
+                        ch == '_';
+            };
+            for (QChar &c : initNameStr) {
+                if (!isAsciiLetterOrNumber(c))
+                    c = QLatin1Char('_');
+            }
         }
         QByteArray initName = initNameStr.toLatin1();