diff options
| author | Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> | 2013-09-13 12:39:49 +0200 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-09-13 13:53:50 +0200 |
| commit | 76ef6aac6ad4ef33d648689589a26e73b92897cc (patch) | |
| tree | 9aa7db2e2ff3a1ab0e01fe59e6db237468043752 /src/tools | |
| parent | 31b4461097bd4bd0c128647bab896c2612ef82b0 (diff) | |
QDoc: properly initialize a member
Spotted by valgrind:
==14189== Conditional jump or move depends on uninitialised value(s)
==14189== at 0x47B3FD: DocParser::parse(QString const&, DocPrivate*, QSet<QString> const&, QSet<QString> const&) (doc.cpp:1627)
==14189== by 0x4818AC: Doc::Doc(Location const&, Location const&, QString const&, QSet<QString> const&, QSet<QString> const&) (doc.cpp:2755)
==14189== by 0x4E6C3D: PureDocParser::processQdocComments() (puredocparser.cpp:140)
==14189== by 0x4E6A9E: PureDocParser::parseSourceFile(Location const&, QString const&) (puredocparser.cpp:109)
==14189== by 0x4D2E4C: processQdocconfFile(QString const&) (main.cpp:473)
==14189== by 0x4D3B3C: main (main.cpp:656)
==14189== Uninitialised value was created by a heap allocation
==14189== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==14189== by 0x474378: DocPrivate::constructExtra() (doc.cpp:415)
==14189== by 0x47B975: DocParser::insertTarget(QString const&, bool) (doc.cpp:1676)
==14189== by 0x476B52: DocParser::parse(QString const&, DocPrivate*, QSet<QString> const&, QSet<QString> const&) (doc.cpp:956)
==14189== by 0x4818AC: Doc::Doc(Location const&, Location const&, QString const&, QSet<QString> const&, QSet<QString> const&) (doc.cpp:2755)
==14189== by 0x4E6C3D: PureDocParser::processQdocComments() (puredocparser.cpp:140)
==14189== by 0x4E6A9E: PureDocParser::parseSourceFile(Location const&, QString const&) (puredocparser.cpp:109)
==14189== by 0x4D2E4C: processQdocconfFile(QString const&) (main.cpp:473)
==14189== by 0x4D3B3C: main (main.cpp:656)
Change-Id: I5c50c6611a1d901cc19d12bc3757977c36b2a73b
Reviewed-by: Martin Smith <martin.smith@digia.com>
Reviewed-by: Topi Reiniö <topi.reinio@digia.com>
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/qdoc/doc.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/tools/qdoc/doc.cpp b/src/tools/qdoc/doc.cpp index 1e0c66cd08..6e70671d1d 100644 --- a/src/tools/qdoc/doc.cpp +++ b/src/tools/qdoc/doc.cpp @@ -325,7 +325,9 @@ public: QStringMultiMap metaMap; DocPrivateExtra() - : granularity(Doc::Part) { } + : granularity(Doc::Part) + , section(Doc::NoSection) + { } }; struct Shared // ### get rid of |