summaryrefslogtreecommitdiffstats
path: root/src/tools
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2019-11-26 12:22:31 +0100
committerEdward Welbourne <edward.welbourne@qt.io>2019-11-27 18:27:43 +0100
commitc20c7efea96046bebcb8ff7823d3a7e227f92e73 (patch)
treeeb4626f2bff53725a4c152a0171acb728bc83e18 /src/tools
parent52affd322cad474efc9235e09f9f5e85f558b7a4 (diff)
Sanitize QAndroidTimeZonePrivate::init()
It was setting the system zone ID if it somehow managed to find a match for an empty zone name; that makes no sense. A case-insensitive comparison seems reasonable for the "this isn't just a default zone object, used because the name I asked for isn't recognized" check. It set m_id after it had checked everything, where it could just as well have used m_id as the variable in which to record whether its check has succeeded already. It was using the name it was asked for, rather than the one this ended up being mapped to, which is probably a better name to use for it. (This should only differ in case.) Split a long line. Change-Id: I41a3b01ba99522ee68f3d7941c532019b9ebf946 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Diffstat (limited to 'src/tools')
0 files changed, 0 insertions, 0 deletions