diff options
author | Sérgio Martins <sergio.martins@kdab.com> | 2015-06-27 17:27:35 +0100 |
---|---|---|
committer | Marc Mutz <marc.mutz@kdab.com> | 2015-07-08 12:32:08 +0000 |
commit | e326cd8d4d89dc96f39038dbf75396ec3e32f26c (patch) | |
tree | 5d1dd61dfb4050727aca9c95e9f2cdae93cf77a1 /src/widgets/accessible | |
parent | 712d605c4343f33390ddfe92e504cb35f478a542 (diff) |
Fix inefficient code foreaching on container.values()
Saves one full iteration and memory allocation.
Change-Id: Ice527499b5f5f62bd1e47d76fdf40119948ee3a1
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
Diffstat (limited to 'src/widgets/accessible')
-rw-r--r-- | src/widgets/accessible/complexwidgets.cpp | 2 | ||||
-rw-r--r-- | src/widgets/accessible/itemviews.cpp | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/widgets/accessible/complexwidgets.cpp b/src/widgets/accessible/complexwidgets.cpp index 60a1329d5e..649a7f4363 100644 --- a/src/widgets/accessible/complexwidgets.cpp +++ b/src/widgets/accessible/complexwidgets.cpp @@ -172,7 +172,7 @@ QAccessibleTabBar::QAccessibleTabBar(QWidget *w) QAccessibleTabBar::~QAccessibleTabBar() { - foreach (QAccessible::Id id, m_childInterfaces.values()) + foreach (QAccessible::Id id, m_childInterfaces) QAccessible::deleteAccessibleInterface(id); } diff --git a/src/widgets/accessible/itemviews.cpp b/src/widgets/accessible/itemviews.cpp index ca2fd62994..23a459c7e6 100644 --- a/src/widgets/accessible/itemviews.cpp +++ b/src/widgets/accessible/itemviews.cpp @@ -94,7 +94,7 @@ bool QAccessibleTable::isValid() const QAccessibleTable::~QAccessibleTable() { - Q_FOREACH (QAccessible::Id id, childToId.values()) + Q_FOREACH (QAccessible::Id id, childToId) QAccessible::deleteAccessibleInterface(id); } @@ -532,7 +532,7 @@ void QAccessibleTable::modelChange(QAccessibleTableModelChangeEvent *event) switch (event->modelChangeType()) { case QAccessibleTableModelChangeEvent::ModelReset: - Q_FOREACH (QAccessible::Id id, childToId.values()) + Q_FOREACH (QAccessible::Id id, childToId) QAccessible::deleteAccessibleInterface(id); childToId.clear(); break; |