diff options
author | Timur Pocheptsov <timur.pocheptsov@qt.io> | 2018-10-30 10:43:51 +0100 |
---|---|---|
committer | Timur Pocheptsov <timur.pocheptsov@qt.io> | 2018-11-02 05:00:14 +0000 |
commit | 611423099667d2dc18e6fb63967cbbfd8a65829c (patch) | |
tree | 3e736b682dfadc09377b6c613a6d070f26cced3c /src/widgets/dialogs/qcolordialog.cpp | |
parent | e3a552a130fc09725c8adda3548d297fc96e058a (diff) |
Fix supportsSsl() to make it more consistent
Attempts to use QSslSocket and its OpenSSL 1.1 back-end with OpenSSL 1.1.1
in a very peculiar way (for some reason the reporter calls OPENSSL_no_config())
combined with a bug in OpenSSL 1.1.1 resulted in a QSslSocket dead-locking
in initialization. This was happening because supportsSsl() first reported
false (OpenSSL internally fails to initialize after OPENSSL_no_config()),
but we have s_libraryLoaded set to true too early, thus the first supportsSsl()
returns false, the second - true.
Move setting of s_libraryLoaded later so that we don't claim to support
OpenSSL when an earlier ensureLibraryLoaded() attempt failed.
Task-number: QTBUG-70956
Task-number: QTBUG-71446
Change-Id: I8ad8763d357c84fc38c62e2ce914366367c2b445
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/widgets/dialogs/qcolordialog.cpp')
0 files changed, 0 insertions, 0 deletions