diff options
author | Huang Jie <huangjie@uniontech.com> | 2021-03-03 17:44:21 +0800 |
---|---|---|
committer | Christian Ehrlicher <ch.ehrlicher@gmx.de> | 2021-03-04 02:33:03 +0000 |
commit | 8a226cd76b96527970b1600f6975c13eccddf109 (patch) | |
tree | 40592757bcebebd12c56db64cb67203a8e03b590 /src/widgets/dialogs | |
parent | 6e334a85a82f1fedc39f54511a9d1b0c7b512d5b (diff) |
Variable is Assigned a never used value in qt_make_filter_list()
Variable 'i' is assigned a value that is never used in qt_make_filter_list()
Pick-to: 6.1
Change-Id: Id845ecb5231b97a899443bdcb9f49cccb7f20bea
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Diffstat (limited to 'src/widgets/dialogs')
-rw-r--r-- | src/widgets/dialogs/qfiledialog.cpp | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/src/widgets/dialogs/qfiledialog.cpp b/src/widgets/dialogs/qfiledialog.cpp index ad2a025090..931b8a69e3 100644 --- a/src/widgets/dialogs/qfiledialog.cpp +++ b/src/widgets/dialogs/qfiledialog.cpp @@ -1335,21 +1335,14 @@ QList<QUrl> QFileDialog::selectedUrls() const */ QStringList qt_make_filter_list(const QString &filter) { - QString f(filter); - - if (f.isEmpty()) + if (filter.isEmpty()) return QStringList(); QString sep(QLatin1String(";;")); - int i = f.indexOf(sep, 0); - if (i == -1) { - if (f.indexOf(QLatin1Char('\n'), 0) != -1) { - sep = QLatin1Char('\n'); - i = f.indexOf(sep, 0); - } - } + if (!filter.contains(sep) && filter.contains(QLatin1Char('\n'))) + sep = QLatin1Char('\n'); - return f.split(sep); + return filter.split(sep); } /*! |