path: root/src/widgets/dialogs
diff options
authorThorbjørn Lund Martsum <>2012-03-07 16:02:47 +0100
committerQt by Nokia <>2012-03-08 21:19:26 +0100
commitdbab994b2cdc5469cf53e3f6c5d09bc2d7b39ce9 (patch)
treec4e68abf7a539b42e3e66d35c2b7c163f46dc1bb /src/widgets/dialogs
parentc614bf25fef7e5a0e0fc7d74980f48a471b4406f (diff)
QDialog - Change exec() and open() to virtual functions
QDialog is meant for inheritance (it contains other virtual functions) ... The main reason for this is that we inside the dialog could have a (datadepened) precondition that should prevent the dialog from being shown at all - instead we might just want to show a messagebox. That is not easy solvable in Qt right now. It is possible to reimplement setVisible - but calling reject from setVisible does not work. There seems only to be clumsy solutions to that problem - unless these functions are made virtual Beside it also creates a nice symmetry to done. Change-Id: I51c29e1f7a4a5522f5c0f71bcf98c943580790b9 Reviewed-by: Friedemann Kleint <> Reviewed-by: Andreas Aardal Hanssen <> Reviewed-by: Robin Burchell <>
Diffstat (limited to 'src/widgets/dialogs')
1 files changed, 2 insertions, 2 deletions
diff --git a/src/widgets/dialogs/qdialog.h b/src/widgets/dialogs/qdialog.h
index 7d3052a782..f20ff46d41 100644
--- a/src/widgets/dialogs/qdialog.h
+++ b/src/widgets/dialogs/qdialog.h
@@ -91,8 +91,8 @@ Q_SIGNALS:
void rejected();
public Q_SLOTS:
- void open();
- int exec();
+ virtual void open();
+ virtual int exec();
virtual void done(int);
virtual void accept();
virtual void reject();