path: root/src/widgets/doc/snippets/
diff options
authorTor Arne Vestbø <>2016-10-13 15:54:23 +0200
committerTor Arne Vestbø <>2016-10-14 08:19:29 +0000
commit6a35e77ef3f4eae80ca49937c680836eb4acdbe6 (patch)
tree12462105731748d75d1fa1b7b45daf586b402413 /src/widgets/doc/snippets/
parentdcf7da7c93c0d974bfb72ffa677a1d26fb9be5e0 (diff)
Change confusing Q_DEAD_CODE_FROM_QT4_FOO define
Commit c5db8fc74 changed all instances of Q_WS_FOO to have the prefix Q_DEAD_CODE_FROM_QT4 instead, to make it clearer when reading the code that the code in question was a left-over from Qt4, when we used Q_WS_ defines instead of Q_OS_ defines. This worked well for cases of #ifdef Q_DEAD_CODE_FROM_QT4, but less so for cases of #ifndef Q_DEAD_CODE_FROM_QT4, where the code was actually unconditionally included. To make this even clearer, the defines have been replaced by checks for 1 or 0, with a comment describing how the code used to look in Qt4. The use of constants in the check also makes it easier for editors to parse the condition and show visually that the code is defined out. Change-Id: I152070d87334df7259b417cd5e17d7b7950379b7 Reviewed-by: Lars Knoll <>
Diffstat (limited to 'src/widgets/doc/snippets/')
1 files changed, 2 insertions, 2 deletions
diff --git a/src/widgets/doc/snippets/ b/src/widgets/doc/snippets/
index f74f8453c7..d848e6442d 100644
--- a/src/widgets/doc/snippets/
+++ b/src/widgets/doc/snippets/
@@ -41,7 +41,7 @@
#include <QtGui>
+#if 0 // Used to be included in Qt4 for Q_WS_MAC
#include <Carbon/Carbon.h>
@@ -289,4 +289,4 @@ QAbstractItemModel *MacMainWindow::createDocumentModel()
return model;