summaryrefslogtreecommitdiffstats
path: root/src/widgets/graphicsview/qgraphicsview.cpp
diff options
context:
space:
mode:
authorThiago Macieira <thiago.macieira@intel.com>2020-03-05 15:31:38 -0800
committerThiago Macieira <thiago.macieira@intel.com>2020-03-20 13:18:00 -0800
commit30a0787907981da3811390735bf234068fc89944 (patch)
treef3334bf1113fa3f4ba54166b383a8693ccc40613 /src/widgets/graphicsview/qgraphicsview.cpp
parentc798b286bdef4026b222e4e030faa36387e32d65 (diff)
Fix binary compatibility issue in QJson{Array,Object} initializer_list
The rewrite using CBOR internals replaced one of the two naked pointers that were members of QJsonArray and QJsonObject with a QExplicitlySharedDataPointer. The problem is that its operator= will read the current value to decrement the refcount and possibly delete the pointed object. But QJson{Array,Object}::initialize() are called from inlined code, without initialization. So we can't call operator=. We need to memcpy to write a nullptr. This is not unit-testable because it requires compiling against 5.14 or earlier, then running against 5.15. Fixes: QTBUG-82700 Change-Id: Iaa63461109844e978376fffd15f98c62656d197c Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'src/widgets/graphicsview/qgraphicsview.cpp')
0 files changed, 0 insertions, 0 deletions