diff options
author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-07-03 10:58:00 +0200 |
---|---|---|
committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-08-17 15:08:39 +0200 |
commit | c4366ff0183a9a4a5c6eff0312b713e9c5eb97ea (patch) | |
tree | de2f4abe6a332b334f7126b418a31dce21915aea /src/widgets/itemviews | |
parent | c2bc4467f774f430a6d536d9c0e70687dbd2301c (diff) |
Remove call to static QGuiApplication::keyboardModifiers method
The event handler listens to the relevant input events already to
read the state of the modifiers. The implementation doesn't care about
touch, wheel, or tablet events either way.
The call was introduced in 28a21d98ef8d880a6dd86ee19dd803424bb5eae1,
with no explanation why it would be necessary, and no test cases to
exercise that case.
Task-number: QTBUG-73829
Change-Id: Ibe408e86f697ac5acae5944b941f0d935ca2e408
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Diffstat (limited to 'src/widgets/itemviews')
-rw-r--r-- | src/widgets/itemviews/qabstractitemview.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/widgets/itemviews/qabstractitemview.cpp b/src/widgets/itemviews/qabstractitemview.cpp index bc35679492..fc1c55114c 100644 --- a/src/widgets/itemviews/qabstractitemview.cpp +++ b/src/widgets/itemviews/qabstractitemview.cpp @@ -3929,7 +3929,7 @@ QItemSelectionModel::SelectionFlags QAbstractItemView::selectionCommand(const QM keyModifiers = (static_cast<const QInputEvent*>(event))->modifiers(); break; default: - keyModifiers = QGuiApplication::keyboardModifiers(); + break; } } switch (d->selectionMode) { @@ -3987,7 +3987,7 @@ QItemSelectionModel::SelectionFlags QAbstractItemViewPrivate::multiSelectionComm QItemSelectionModel::SelectionFlags QAbstractItemViewPrivate::extendedSelectionCommand( const QModelIndex &index, const QEvent *event) const { - Qt::KeyboardModifiers modifiers = QGuiApplication::keyboardModifiers(); + Qt::KeyboardModifiers modifiers = Qt::NoModifier; if (event) { switch (event->type()) { case QEvent::MouseMove: { |