QApplication: replace some sneaky code with a strategic goto

Instead of replacing the container iterated over, in the middle
of the loop body(!), place a label in front of the loop and
use goto to restart the entire loop.

This allows to mark the variable 'list' const, which is a
prerequesite for replacing the loop with a C++11 range-for
one.

But it also makes the code less cryptic. No-one expects the
container to be re-seated in the middle of the loop.

The compiler agrees: saves 144b of text size on optimized
AMD64 GCC 4.9 Linux builds.

Change-Id: I22d07672a1bbe9d7ffb083ae231eda760c29d350
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>

0 files changed, 0 insertions, 0 deletions