diff options
author | Axel Spoerl <axel.spoerl@qt.io> | 2023-11-17 12:25:14 +0100 |
---|---|---|
committer | Axel Spoerl <axel.spoerl@qt.io> | 2023-11-18 20:48:21 +0100 |
commit | 0b10b7476cf9d41086063ec49555425c6871041c (patch) | |
tree | 1418a0df86a75c68d85c4e2758486921e5591e8f /src/widgets/widgets/qmainwindowlayout_p.h | |
parent | b6b489db6968fbc3b4aab3755d0166ee09712ff0 (diff) |
Refactor tst_QDockWidget::closeAndDelete()
The test function was temporarily blacklisted on Ubuntu, but also
failing on other Linux platforms (e.g. openSuSE).
It tested, whether closing all dock widgets and the main window, would
close the application as well. It used one single shot timer, to close
the windows and later one to check, whether the application was shut
down.
While that mechanism must work in an application environment, it is not
guaranteed to work in testlib. More specifically, I could happen that
the XCB / glib event loop continued to spin and wait for events.
=> Check the signal QGuiApplication::lastWindowClosed() instead. If the
signal is fired, it is proven that all windows have been closed and
the application would quit in a production environment.
The underlying test case was: Application didn't quit with the last
dock widget closed, because there was a dangling
QDockWidgetGroupWindow.
=> finally: Clean up BLACKLIST
Pick-to: 6.6 6.5
Change-Id: Ic5fde5967fc8dde70ab64dc30cc7367c908b5c51
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/widgets/widgets/qmainwindowlayout_p.h')
0 files changed, 0 insertions, 0 deletions