Sync default action when checking tool button programmatically

QAbstractButton::setChecked is not virtual, so QToolButton cannot
override to synchronize the default action's checked state. This resulted
in button and default action not being in sync when the checked state
of the button was changed programmatically, while changing the checked
state on the action kept the button in sync.

Connect to the button's own toggled signal instead to keep the state of
the default action in sync. Make it a unique connection to allow multiple
calls to setDefaultAction, which are used by QToolButton to keep the
button updated if properties of the default action change.

Add a test that confirms that button and action are synchronized both
ways, and that we only get single signal emissions when changing either
programmatically.

Fixes: QTBUG-95255
Pick-to: 6.2 6.1
Change-Id: I0e027faf1da763ef1878e46e85bfa70073c8bf82
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

1 files changed, 6 insertions, 0 deletions

diff --git a/src/widgets/widgets/qtoolbutton.cpp b/src/widgets/widgets/qtoolbutton.cpp
index b9d31bd657..ee58797d3c 100644
--- a/src/widgets/widgets/qtoolbutton.cpp
+++ b/src/widgets/widgets/qtoolbutton.cpp
@@ -961,6 +961,12 @@ void QToolButton::setDefaultAction(QAction *action)
     }
 #endif
     setCheckable(action->isCheckable());
+    if (action->isCheckable()) {
+        connect(this, &QAbstractButton::toggled, this, [this](bool checked) {
+            if (defaultAction())
+                defaultAction()->setChecked(checked);
+        }, Qt::UniqueConnection);
+    }
     setChecked(action->isChecked());
     setEnabled(action->isEnabled());
     if (action->d_func()->fontSet)