diff options
author | Edward Welbourne <edward.welbourne@theqtcompany.com> | 2016-01-18 13:03:49 +0100 |
---|---|---|
committer | Edward Welbourne <edward.welbourne@theqtcompany.com> | 2016-04-06 14:52:16 +0000 |
commit | 6a7f5dab0d6e86950f87123c69724018aa140770 (patch) | |
tree | d143fd81b287b671d33a550667edac4e68dfa387 /src/xml | |
parent | 6fae048af52622db99221a98fd721b59a1bca260 (diff) |
Explain QTimeZonePrivate::isValidId a bit more carefully.
Its "rules" are actually guidelines, its suggested regex was wrong,
its actual implementation was fuzzier than its documentation suggested
and the exception it tacitly permitted should be distinguished from
the stricter rules it otherwise appears to implement. There was also
a redundant check ('-' had been handled earlier in the chained if).
Explain why the situation is tricky, fix the regex mentioned (making
it more readable, too) and note what might be worth doing a little
more fussily, without actually changing code behavior.
Change-Id: I93fa0da0640a134e5d84011b435a186576824063
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Diffstat (limited to 'src/xml')
0 files changed, 0 insertions, 0 deletions