diff options
author | Marc Mutz <marc.mutz@qt.io> | 2022-09-30 14:09:04 +0200 |
---|---|---|
committer | Marc Mutz <marc.mutz@qt.io> | 2022-10-04 07:40:08 +0200 |
commit | df9d882d41b741fef7c5beeddb0abe9d904443d8 (patch) | |
tree | 6f3e90dacad4581b7f1cabe235cca298833a3da4 /src/xml | |
parent | 109e088c7c5d0c9325966e88d55fd9f7a58f67ea (diff) |
Port from container.count()/length() to size()
This is semantic patch using ClangTidyTransformator:
auto QtContainerClass = expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)
makeRule(cxxMemberCallExpr(on(QtContainerClass),
callee(cxxMethodDecl(hasAnyName({"count", "length"),
parameterCountIs(0))))),
changeTo(cat(access(o, cat("size"), "()"))),
cat("use 'size()' instead of 'count()/length()'"))
a.k.a qt-port-to-std-compatible-api with config Scope: 'Container'.
<classes> are:
// sequential:
"QByteArray",
"QList",
"QQueue",
"QStack",
"QString",
"QVarLengthArray",
"QVector",
// associative:
"QHash",
"QMultiHash",
"QMap",
"QMultiMap",
"QSet",
// Qt has no QMultiSet
Change-Id: Ibe8837be96e8d30d1846881ecd65180c1bc459af
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/xml')
-rw-r--r-- | src/xml/dom/qdom.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/xml/dom/qdom.cpp b/src/xml/dom/qdom.cpp index d02f3be7ec..6b86d3641c 100644 --- a/src/xml/dom/qdom.cpp +++ b/src/xml/dom/qdom.cpp @@ -728,7 +728,7 @@ int QDomNodeListPrivate::length() const that->createList(); } - return list.count(); + return list.size(); } /************************************************************** @@ -2628,7 +2628,7 @@ QDomNodePrivate* QDomNamedNodeMapPrivate::item(int index) const int QDomNamedNodeMapPrivate::length() const { - return map.count(); + return map.size(); } bool QDomNamedNodeMapPrivate::contains(const QString& name) const @@ -3354,7 +3354,7 @@ QDomNodePrivate* QDomCharacterDataPrivate::cloneNode(bool deep) int QDomCharacterDataPrivate::dataLength() const { - return value.length(); + return value.size(); } QString QDomCharacterDataPrivate::substringData(unsigned long offset, unsigned long n) const @@ -3612,7 +3612,7 @@ static QString encodeText(const QString &str, const bool encodeEOLs = false) { QString retval(str); - int len = retval.length(); + int len = retval.size(); int i = 0; while (i < len) { @@ -3640,8 +3640,8 @@ static QString encodeText(const QString &str, ati == QChar(0x9))) { const QString replacement(u"&#x"_s + QString::number(ati.unicode(), 16) + u';'); retval.replace(i, 1, replacement); - i += replacement.length(); - len += replacement.length() - 1; + i += replacement.size(); + len += replacement.size() - 1; } else if (encodeEOLs && ati == QChar(0xD)) { retval.replace(i, 1, "
"_L1); // Replace a single 0xD with a ref for 0xD len += 4; |