diff options
author | Jason McDonald <jason.mcdonald@nokia.com> | 2011-11-10 12:59:56 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2011-11-14 07:33:57 +0100 |
commit | 578e6d6834ae8608fb98f1f871e7bd21d64aaf1e (patch) | |
tree | 65cb486e2ca15355415280bccd4cca78a6d8e9f3 /tests/auto/corelib/io/qfilesystemwatcher/tst_qfilesystemwatcher.cpp | |
parent | 3e0dece1518989bfd6cf5769e574ce199670ec88 (diff) |
Cleanup corelib autotests
Remove various disabled and/or non-helpful debugging code.
Any test diagnostics that are useful should be part of the regular test
output, as the CI system cannot switch on commented-out code when there
is a test failure. Diagnostics should also be informative -- simply
printing the value of a variable with no other information about what is
being printed (or why it is being printed) is not informative.
Change-Id: I21a6c2121be86001bb57e80f426507b6e619ee9e
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Diffstat (limited to 'tests/auto/corelib/io/qfilesystemwatcher/tst_qfilesystemwatcher.cpp')
-rw-r--r-- | tests/auto/corelib/io/qfilesystemwatcher/tst_qfilesystemwatcher.cpp | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/tests/auto/corelib/io/qfilesystemwatcher/tst_qfilesystemwatcher.cpp b/tests/auto/corelib/io/qfilesystemwatcher/tst_qfilesystemwatcher.cpp index 63f51f743c..08a5e3ae3d 100644 --- a/tests/auto/corelib/io/qfilesystemwatcher/tst_qfilesystemwatcher.cpp +++ b/tests/auto/corelib/io/qfilesystemwatcher/tst_qfilesystemwatcher.cpp @@ -161,7 +161,7 @@ void tst_QFileSystemWatcher::basicTest() testFile.write(QByteArray("world")); testFile.close(); - // qDebug() << "waiting max 5 seconds for notification for file modification to trigger(1)"; + // waiting max 5 seconds for notification for file modification to trigger timer.start(5000); eventLoop.exec(); @@ -179,7 +179,7 @@ void tst_QFileSystemWatcher::basicTest() testFile.write(QByteArray("hello universe!")); testFile.close(); - // qDebug() << "waiting max 5 seconds for notification for file modification to trigger (2)"; + // waiting max 5 seconds for notification for file modification to trigger timer.start(5000); eventLoop.exec(); @@ -206,7 +206,7 @@ void tst_QFileSystemWatcher::basicTest() // change the permissions, should get a signal from the watcher testFile.setPermissions(QFile::ReadOwner); - // qDebug() << "waiting max 5 seconds for notification for file permission modification to trigger(1)"; + // waiting max 5 seconds for notification for file permission modification to trigger timer.start(5000); eventLoop.exec(); @@ -222,7 +222,7 @@ void tst_QFileSystemWatcher::basicTest() watcher.removePath(testFile.fileName()); testFile.setPermissions(QFile::ReadOwner | QFile::WriteOwner | QFile::ExeOther); - // qDebug() << "waiting max 5 seconds for notification for file modification to trigger (2)"; + // waiting max 5 seconds for notification for file modification to trigger timer.start(5000); eventLoop.exec(); @@ -234,7 +234,7 @@ void tst_QFileSystemWatcher::basicTest() // remove the file, should get a signal from the watcher QVERIFY(testFile.remove()); - // qDebug() << "waiting max 5 seconds for notification for file removal to trigger"; + // waiting max 5 seconds for notification for file removal to trigger timer.start(5000); eventLoop.exec(); @@ -251,7 +251,7 @@ void tst_QFileSystemWatcher::basicTest() testFile.write(QByteArray("hello")); testFile.close(); - // qDebug() << "waiting max 5 seconds for notification for file recreation to trigger"; + // waiting max 5 seconds for notification for file recreation to trigger timer.start(5000); eventLoop.exec(); @@ -292,7 +292,7 @@ void tst_QFileSystemWatcher::watchDirectory() QVERIFY(testFile.open(QIODevice::WriteOnly | QIODevice::Truncate)); testFile.close(); - // qDebug() << "waiting max 5 seconds for notification for file recreationg to trigger"; + // waiting max 5 seconds for notification for file recreationg to trigger timer.start(5000); eventLoop.exec(); @@ -309,7 +309,7 @@ void tst_QFileSystemWatcher::watchDirectory() // remove the directory, should get a signal from the watcher QVERIFY(QDir().rmdir("testDir")); - // qDebug() << "waiting max 5 seconds for notification for directory removal to trigger"; + // waiting max 5 seconds for notification for directory removal to trigger timer.start(5000); eventLoop.exec(); @@ -331,7 +331,7 @@ void tst_QFileSystemWatcher::watchDirectory() if (!QDir().mkdir("testDir")) QSKIP("Failed to recreate directory, skipping final test."); - // qDebug() << "waiting max 5 seconds for notification for dir recreation to trigger"; + // waiting max 5 seconds for notification for dir recreation to trigger timer.start(5000); eventLoop.exec(); |