diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2022-05-17 10:19:41 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2022-06-07 06:46:12 +0000 |
| commit | 0da17e83ec507229e3516bbdc5986ab775dc843e (patch) | |
| tree | cf2f817ac6cf12a4df1e2d11e4f9cd54b5eaab68 /tests/auto/corelib/io | |
| parent | d6575f37179aef80490f4ec03a61ab6f5033bd3d (diff) | |
Fix data race in QCoreApplicationPrivate::sendThroughApplicationEventFilters()
The assertion has the acquire fence at the wrong place:
- QThreadData::thread isn't dereferenced, so the acquire fence on its
load() isn't needed.
- QObjectPrivate::threadData, however, _is_ dereferenced, so an
acquire fence is needed; the relaxed load() is insufficient.
Swapping the loadAcquire() and the loadRelaxed() fixes both issues.
Pick-to: 6.4 6.3 6.2 5.15
Change-Id: Iee964490e93ebc323c188e616bf0d448f91fb2b5
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'tests/auto/corelib/io')
0 files changed, 0 insertions, 0 deletions