diff options
author | Jason McDonald <jason.mcdonald@nokia.com> | 2011-11-24 17:34:51 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2011-11-25 07:56:16 +0100 |
commit | e08410ab8db3d7cabf4ef2fc4de40bb6da6d6fef (patch) | |
tree | 9d6e154364039ab6cbc7a789ef33b7e0ce038e51 /tests/auto/corelib/kernel/qtimer | |
parent | 489a39aacc102e46a5b3fffd5839ed694bb7214f (diff) |
Cleanup corelib autotests
Bug trackers come and go, so using bug identifiers in function and test
case names will ensure that those names eventually become meaningless.
It is better to choose a meaningful name and provide explanatory
comments where appropriate.
Change-Id: I67c27782ef21b5d4eaab4854079a043c8ef6957b
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Diffstat (limited to 'tests/auto/corelib/kernel/qtimer')
-rw-r--r-- | tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp b/tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp index f70c380c4a..c66e5ff80b 100644 --- a/tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp +++ b/tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp @@ -74,7 +74,7 @@ private slots: void singleShotStaticFunctionZeroTimeout(); void recurseOnTimeoutAndStopTimer(); - void QTBUG13633_dontBlockEvents(); + void dontBlockEvents(); void postedEventsShouldNotStarveTimers(); }; @@ -634,7 +634,7 @@ DontBlockEvents::DontBlockEvents() count = 0; total = 0; - //QTBUG-13633 need few unrelated timer running to reproduce the bug. + // need a few unrelated timers running to reproduce the bug. (new QTimer(this))->start(2000); (new QTimer(this))->start(2500); (new QTimer(this))->start(3000); @@ -662,8 +662,9 @@ void DontBlockEvents::paintEvent() QCOMPARE(count, 0); } - -void tst_QTimer::QTBUG13633_dontBlockEvents() +// This is a regression test for QTBUG-13633, where a timer with a zero +// timeout that was restarted by the event handler could starve other timers. +void tst_QTimer::dontBlockEvents() { DontBlockEvents t; QTest::qWait(60); |