diff options
author | Edward Welbourne <edward.welbourne@qt.io> | 2022-01-28 15:28:14 +0100 |
---|---|---|
committer | Marc Mutz <marc.mutz@qt.io> | 2022-02-09 20:46:24 +0000 |
commit | 0828014b44de4365de9f3724f5c798025c00010e (patch) | |
tree | 5c6c9884c30ea2e86aed77c410fc7c15f46536a6 /tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp | |
parent | 15bcf03f3ed8c27a0f2c6a60abdfa546576ab58e (diff) |
Fix an inaccurate comment and update a test case
The offset fields for tst_QTimeZone::specificTransition() had a
comment claiming they are in minutes; they are in fact in seconds, so
fix that. At the same time, Moscow hasn't had a time-zone change since
2017, so the end-date for one of the test intervals can be nudged a
little closer to the present without harm.
Change-Id: I66822cb758f7e00d6added801466a6745be3e31a
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp')
-rw-r--r-- | tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp b/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp index f68aeced2f..a9d552fd03 100644 --- a/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp +++ b/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp @@ -527,7 +527,7 @@ void tst_QTimeZone::specificTransition_data() QTest::addColumn<QDate>("stop"); QTest::addColumn<int>("count"); QTest::addColumn<QDateTime>("atUtc"); - // In minutes: + // In seconds: QTest::addColumn<int>("offset"); QTest::addColumn<int>("stdoff"); QTest::addColumn<int>("dstoff"); @@ -544,7 +544,7 @@ void tst_QTimeZone::specificTransition_data() { QTest::newRow("Moscow/2014") // From original bug-report << QByteArray("Europe/Moscow") - << QDate(2011, 4, 1) << QDate(2017, 12,31) << 1 + << QDate(2011, 4, 1) << QDate(2021, 12, 31) << 1 << QDateTime(QDate(2014, 10, 26), QTime(2, 0, 0), Qt::OffsetFromUTC, 4 * 3600).toUTC() << 3 * 3600 << 3 * 3600 << 0; |