Tests: make some QFile::open calls fail

In some cases calls to QFile::open are made outside of a testfunction
(so we can't use QVERIFY), or even in standalone executables that are
executed by tests. Make them fail "visibly".

Change-Id: Iec4d56f6d874be16aa2e9ad6974eeec2a98caa3f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

3 files changed, 12 insertions, 7 deletions

diff --git a/tests/auto/corelib/io/qfile/stdinprocess/main.cpp b/tests/auto/corelib/io/qfile/stdinprocess/main.cpp
index dbcd00bb0a..0f92ba2670 100644
--- a/tests/auto/corelib/io/qfile/stdinprocess/main.cpp
+++ b/tests/auto/corelib/io/qfile/stdinprocess/main.cpp
@@ -16,13 +16,16 @@ int main(int argc, char *argv[])
     QFile file;
 
     if (strcmp(argv[1], "all") == 0) {
-        file.open(stdin, QFile::ReadWrite);
+        if (!file.open(stdin, QFile::ReadWrite))
+            return 1;
         printf("%s", file.readAll().constData());
     } else if (strcmp(argv[1], "line") == 0) {
         if (strcmp(argv[2], "0") == 0) {
-            file.open(stdin, QFile::ReadWrite);
+            if (!file.open(stdin, QFile::ReadWrite))
+                return 1;
         } else {
-            file.open(0, QFile::ReadWrite);
+            if (!file.open(0, QFile::ReadWrite))
+                return 1;
         }
 
         char line[1024];
diff --git a/tests/auto/corelib/io/qprocess/fileWriterProcess/main.cpp b/tests/auto/corelib/io/qprocess/fileWriterProcess/main.cpp
index 43b3f77188..0349a48067 100644
--- a/tests/auto/corelib/io/qprocess/fileWriterProcess/main.cpp
+++ b/tests/auto/corelib/io/qprocess/fileWriterProcess/main.cpp
@@ -9,7 +9,8 @@ int main(int argc, char **argv)
 {
     QCoreApplication ca(argc, argv);
     QFile f;
-    f.open(stdin, QIODevice::ReadOnly);
+    if (!f.open(stdin, QIODevice::ReadOnly))
+        return 1;
     QByteArray input;
     char buf[1024];
     qint64 len;
diff --git a/tests/auto/corelib/serialization/qxmlstream/tst_qxmlstream.cpp b/tests/auto/corelib/serialization/qxmlstream/tst_qxmlstream.cpp
index 0b7d9ab0ed..436ff676f6 100644
--- a/tests/auto/corelib/serialization/qxmlstream/tst_qxmlstream.cpp
+++ b/tests/auto/corelib/serialization/qxmlstream/tst_qxmlstream.cpp
@@ -95,8 +95,8 @@ static QByteArray makeCanonical(const QString &filename,
                                 bool testIncremental = false)
 {
     QFile file(filename);
-    file.open(QIODevice::ReadOnly);
-
+    if (!file.open(QIODevice::ReadOnly))
+        qFatal("Could not open file %s", qPrintable(filename));
     QXmlStreamReader reader;
 
     QByteArray buffer;
@@ -747,7 +747,8 @@ void tst_QXmlStream::reportSuccess_data() const
 QByteArray tst_QXmlStream::readFile(const QString &filename)
 {
     QFile file(filename);
-    file.open(QIODevice::ReadOnly);
+    if (!file.open(QIODevice::ReadOnly))
+        qFatal("Could not open file %s", qPrintable(filename));
 
     QXmlStreamReader reader;