summaryrefslogtreecommitdiffstats
path: root/tests/auto/dbus/qdbusservicewatcher
diff options
context:
space:
mode:
authorSami Rosendahl <ext-sami.1.rosendahl@nokia.com>2011-11-23 10:03:26 +0200
committerQt by Nokia <qt-info@nokia.com>2011-11-23 19:14:12 +0100
commitb851c764a61c0de781ef3447230a0a6a3f4a0ed9 (patch)
treee027346c7289ecc2a74bf1dd54d6d3531c7911ad /tests/auto/dbus/qdbusservicewatcher
parentc3160c84af3cb14c0edc5896be0ca637377e3805 (diff)
Fix stack overwrite in QDBusDemarshaller
QDBusArgument extraction operators and QDBusDemarshaller that implements the extraction do not check the type of the extracted value. Helper function template qIterGet in qdbusdemarshaller.cpp that is used for extracting basic data types only reserves space from the stack for the expected type as specified by client. If the actual type in the DBus parameter is larger stack will be overwritten in the helper function by at most 7 bytes (expected one byte, received dbus_uint_64_t of size 8 bytes). The fix always reserves space for the largest basic type dbus_uint64_t readable by dbus_message_iter_get_basic API. See also http://dbus.freedesktop.org/doc/api/html/group__DBusMessage.html#ga41c23a05e552d0574d04 Task-number: QTBUG-22735 Change-Id: I9aa25b279852ac8acc40199a39910ea4002042d7 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'tests/auto/dbus/qdbusservicewatcher')
0 files changed, 0 insertions, 0 deletions