diff options
| author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-11-11 12:28:54 +0100 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-11-12 15:25:06 +0100 |
| commit | e796857abb73d44b6862687c353ee4977d22cc77 (patch) | |
| tree | 7333e869e5d9c778d1518d8047dabd64a5b913e8 /tests/auto/gui/kernel/qtouchevent | |
| parent | 03e03d7ceb6da284f217fddd76b35d0c2b002af7 (diff) | |
Stop copying events in tests
It's unnecessary, and copying QEvents is a bad practice since it's a
polymorphic class.
Change-Id: Ieb6de106084f838c5e6c8a0643c54fd3c7f4a7a8
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Diffstat (limited to 'tests/auto/gui/kernel/qtouchevent')
| -rw-r--r-- | tests/auto/gui/kernel/qtouchevent/tst_qtouchevent.cpp | 40 |
1 files changed, 20 insertions, 20 deletions
diff --git a/tests/auto/gui/kernel/qtouchevent/tst_qtouchevent.cpp b/tests/auto/gui/kernel/qtouchevent/tst_qtouchevent.cpp index 58e7fd2eed..8ef63154a8 100644 --- a/tests/auto/gui/kernel/qtouchevent/tst_qtouchevent.cpp +++ b/tests/auto/gui/kernel/qtouchevent/tst_qtouchevent.cpp @@ -345,27 +345,27 @@ void tst_QTouchEvent::state() QVERIFY(touchEvent.isPointerEvent()); QVERIFY(!touchEvent.isSinglePointEvent()); - touchEvent = QTouchEvent(QEvent::TouchBegin, touchScreenDevice, - Qt::NoModifier, QList<QEventPoint>() << - QEventPoint(0, QEventPoint::State::Updated, {}, {}) << - QEventPoint(1, QEventPoint::State::Pressed, {}, {})); - QCOMPARE(touchEvent.touchPointStates(), QEventPoint::State::Updated | QEventPoint::State::Pressed); - QCOMPARE(touchEvent.pointCount(), 2); - QVERIFY(touchEvent.isBeginEvent()); - QVERIFY(!touchEvent.isUpdateEvent()); - QVERIFY(!touchEvent.isEndEvent()); - - touchEvent = QTouchEvent(QEvent::TouchBegin, touchScreenDevice, - Qt::NoModifier, QList<QEventPoint>() << - QEventPoint(0, QEventPoint::State::Updated, {}, {}) << - QEventPoint(1, QEventPoint::State::Released, {}, {})); - QCOMPARE(touchEvent.touchPointStates(), QEventPoint::State::Updated | QEventPoint::State::Released); - QCOMPARE(touchEvent.pointCount(), 2); - QVERIFY(!touchEvent.isBeginEvent()); - QVERIFY(!touchEvent.isUpdateEvent()); - QVERIFY(touchEvent.isEndEvent()); + QTouchEvent touchEvent2 = QTouchEvent(QEvent::TouchBegin, touchScreenDevice, + Qt::NoModifier, QList<QEventPoint>() << + QEventPoint(0, QEventPoint::State::Updated, {}, {}) << + QEventPoint(1, QEventPoint::State::Pressed, {}, {})); + QCOMPARE(touchEvent2.touchPointStates(), QEventPoint::State::Updated | QEventPoint::State::Pressed); + QCOMPARE(touchEvent2.pointCount(), 2); + QVERIFY(touchEvent2.isBeginEvent()); + QVERIFY(!touchEvent2.isUpdateEvent()); + QVERIFY(!touchEvent2.isEndEvent()); + + QTouchEvent touchEvent3 = QTouchEvent(QEvent::TouchBegin, touchScreenDevice, + Qt::NoModifier, QList<QEventPoint>() << + QEventPoint(0, QEventPoint::State::Updated, {}, {}) << + QEventPoint(1, QEventPoint::State::Released, {}, {})); + QCOMPARE(touchEvent3.touchPointStates(), QEventPoint::State::Updated | QEventPoint::State::Released); + QCOMPARE(touchEvent3.pointCount(), 2); + QVERIFY(!touchEvent3.isBeginEvent()); + QVERIFY(!touchEvent3.isUpdateEvent()); + QVERIFY(touchEvent3.isEndEvent()); QT_WARNING_PUSH QT_WARNING_DISABLE_DEPRECATED // test Qt 5 compatibility wrappers - QCOMPARE(touchEvent.touchPoints(), touchEvent.points()); + QCOMPARE(touchEvent3.touchPoints(), touchEvent3.points()); QT_WARNING_POP } |