summaryrefslogtreecommitdiffstats
path: root/tests/auto/gui/rhi/qshader/tst_qshader.cpp
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2021-06-11 14:38:24 +0200
committerEdward Welbourne <edward.welbourne@qt.io>2021-06-14 15:57:16 +0200
commitaccdfbb396ee7f1345ce33929dd57c5a571d36f5 (patch)
tree3247003d6346016601ff07db003aea043fe052fa /tests/auto/gui/rhi/qshader/tst_qshader.cpp
parentd2a4a5e60162bb66558ab483679b1943c11caa8b (diff)
Prefer QFAIL("Informative message") over QVERIFY(false)
Change-Id: I706b0aedfa870452331a8c2c488d55b279ee452a Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'tests/auto/gui/rhi/qshader/tst_qshader.cpp')
-rw-r--r--tests/auto/gui/rhi/qshader/tst_qshader.cpp14
1 files changed, 7 insertions, 7 deletions
diff --git a/tests/auto/gui/rhi/qshader/tst_qshader.cpp b/tests/auto/gui/rhi/qshader/tst_qshader.cpp
index 1a57daf220..1b3d861756 100644
--- a/tests/auto/gui/rhi/qshader/tst_qshader.cpp
+++ b/tests/auto/gui/rhi/qshader/tst_qshader.cpp
@@ -1,6 +1,6 @@
/****************************************************************************
**
-** Copyright (C) 2019 The Qt Company Ltd.
+** Copyright (C) 2021 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of the test suite of the Qt Toolkit.
@@ -101,7 +101,7 @@ void tst_QShader::simpleCompileCheckResults()
QCOMPARE(v.type, QShaderDescription::Vec3);
break;
default:
- QVERIFY(false);
+ QFAIL(qPrintable(QStringLiteral("Bad location: %1").arg(v.location)));
break;
}
}
@@ -113,7 +113,7 @@ void tst_QShader::simpleCompileCheckResults()
QCOMPARE(v.type, QShaderDescription::Vec3);
break;
default:
- QVERIFY(false);
+ QFAIL(qPrintable(QStringLiteral("Bad location: %1").arg(v.location)));
break;
}
}
@@ -142,7 +142,7 @@ void tst_QShader::simpleCompileCheckResults()
QCOMPARE(v.type, QShaderDescription::Float);
break;
default:
- QVERIFY(false);
+ QFAIL(qPrintable(QStringLiteral("Too many blocks: %1").arg(blk.members.count())));
break;
}
}
@@ -409,7 +409,7 @@ void tst_QShader::loadV4()
QCOMPARE(v.type, QShaderDescription::Vec2);
break;
default:
- QVERIFY(false);
+ QFAIL(qPrintable(QStringLiteral("Bad location: %1").arg(v.location)));
break;
}
}
@@ -421,7 +421,7 @@ void tst_QShader::loadV4()
QCOMPARE(v.type, QShaderDescription::Vec4);
break;
default:
- QVERIFY(false);
+ QFAIL(qPrintable(QStringLiteral("Bad location: %1").arg(v.location)));
break;
}
}
@@ -450,7 +450,7 @@ void tst_QShader::loadV4()
QCOMPARE(v.type, QShaderDescription::Float);
break;
default:
- QVERIFY(false);
+ QFAIL(qPrintable(QStringLiteral("Bad many blocks: %1").arg(blk.members.count())));
break;
}
}