summaryrefslogtreecommitdiffstats
path: root/tests/auto/gui
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2020-09-10 20:39:49 +0200
committerLars Knoll <lars.knoll@qt.io>2020-09-11 00:20:47 +0200
commit6ae7a02104631a2234c475575ae15ca79bef14f9 (patch)
tree5ca2db0e3aa3c7851c6d19117147c581bebeeee3 /tests/auto/gui
parent459e8dfdfb8ac164383c14332b2b0919f59f8b3c (diff)
Remove most compiler warnings about missing overrides
Remove around 1000 compiler warnings about missing overrides in our auto tests. This significantly reduce the compiler warning noise in our auto tests, so that one can actually better see the real problems inbetween. Change-Id: Id0c04dba43fcaf55d8cd2b5c6697358857c31bf9 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'tests/auto/gui')
-rw-r--r--tests/auto/gui/image/qicoimageformat/tst_qicoimageformat.cpp3
-rw-r--r--tests/auto/gui/image/qimageiohandler/tst_qimageiohandler.cpp4
-rw-r--r--tests/auto/gui/image/qpicture/tst_qpicture.cpp12
-rw-r--r--tests/auto/gui/image/qpixmap/tst_qpixmap.cpp2
-rw-r--r--tests/auto/gui/kernel/qbackingstore/tst_qbackingstore.cpp4
-rw-r--r--tests/auto/gui/kernel/qfileopenevent/test/tst_qfileopenevent.cpp2
-rw-r--r--tests/auto/gui/kernel/qguiapplication/tst_qguiapplication.cpp12
-rw-r--r--tests/auto/gui/kernel/qinputmethod/tst_qinputmethod.cpp4
-rw-r--r--tests/auto/gui/kernel/qkeyevent/tst_qkeyevent.cpp4
-rw-r--r--tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp4
-rw-r--r--tests/auto/gui/kernel/qmouseevent_modal/tst_qmouseevent_modal.cpp2
-rw-r--r--tests/auto/gui/kernel/qwindow/tst_qwindow.cpp3
-rw-r--r--tests/auto/gui/painting/qpaintengine/tst_qpaintengine.cpp10
-rw-r--r--tests/auto/gui/painting/qpainter/tst_qpainter.cpp28
-rw-r--r--tests/auto/gui/qopengl/tst_qopengl.cpp4
-rw-r--r--tests/auto/gui/text/qabstracttextdocumentlayout/tst_qabstracttextdocumentlayout.cpp15
-rw-r--r--tests/auto/gui/text/qcssparser/tst_qcssparser.cpp16
-rw-r--r--tests/auto/gui/text/qstatictext/tst_qstatictext.cpp2
-rw-r--r--tests/auto/gui/text/qsyntaxhighlighter/tst_qsyntaxhighlighter.cpp20
-rw-r--r--tests/auto/gui/text/qtextdocument/common.h14
-rw-r--r--tests/auto/gui/text/qtextdocument/tst_qtextdocument.cpp18
-rw-r--r--tests/auto/gui/text/qtextdocumentfragment/tst_qtextdocumentfragment.cpp3
-rw-r--r--tests/auto/gui/text/qtextlayout/tst_qtextlayout.cpp4
-rw-r--r--tests/auto/gui/text/qtexttable/tst_qtexttable.cpp20
-rw-r--r--tests/auto/gui/util/qundogroup/tst_qundogroup.cpp16
-rw-r--r--tests/auto/gui/util/qundostack/tst_qundostack.cpp28
26 files changed, 130 insertions, 124 deletions
diff --git a/tests/auto/gui/image/qicoimageformat/tst_qicoimageformat.cpp b/tests/auto/gui/image/qicoimageformat/tst_qicoimageformat.cpp
index fe12175081..1716570046 100644
--- a/tests/auto/gui/image/qicoimageformat/tst_qicoimageformat.cpp
+++ b/tests/auto/gui/image/qicoimageformat/tst_qicoimageformat.cpp
@@ -115,7 +115,8 @@ public:
virtual ~QSequentialFile() {}
- virtual bool isSequential() const {
+ virtual bool isSequential() const override
+ {
return true;
}
diff --git a/tests/auto/gui/image/qimageiohandler/tst_qimageiohandler.cpp b/tests/auto/gui/image/qimageiohandler/tst_qimageiohandler.cpp
index e24ba4fa81..9da4d1a1f1 100644
--- a/tests/auto/gui/image/qimageiohandler/tst_qimageiohandler.cpp
+++ b/tests/auto/gui/image/qimageiohandler/tst_qimageiohandler.cpp
@@ -50,8 +50,8 @@ class MyImageIOHandler : public QImageIOHandler
{
public:
MyImageIOHandler() : QImageIOHandler() { }
- bool canRead() const { return true; }
- bool read(QImage *) { return true; }
+ bool canRead() const override { return true; }
+ bool read(QImage *) override { return true; }
};
tst_QImageIOHandler::tst_QImageIOHandler()
diff --git a/tests/auto/gui/image/qpicture/tst_qpicture.cpp b/tests/auto/gui/image/qpicture/tst_qpicture.cpp
index 6287960457..c55a96d697 100644
--- a/tests/auto/gui/image/qpicture/tst_qpicture.cpp
+++ b/tests/auto/gui/image/qpicture/tst_qpicture.cpp
@@ -152,11 +152,11 @@ class PaintEngine : public QPaintEngine
{
public:
PaintEngine() : QPaintEngine() {}
- bool begin(QPaintDevice *) { return true; }
- bool end() { return true; }
- void updateState(const QPaintEngineState &) {}
- void drawPixmap(const QRectF &, const QPixmap &, const QRectF &) {}
- Type type() const { return Raster; }
+ bool begin(QPaintDevice *) override { return true; }
+ bool end() override { return true; }
+ void updateState(const QPaintEngineState &) override {}
+ void drawPixmap(const QRectF &, const QPixmap &, const QRectF &) override {}
+ Type type() const override { return Raster; }
QFont font() { return state->font(); }
};
@@ -165,7 +165,7 @@ class Picture : public QPicture
{
public:
Picture() : QPicture() {}
- QPaintEngine *paintEngine() const { return (QPaintEngine*)&mPaintEngine; }
+ QPaintEngine *paintEngine() const override { return (QPaintEngine*)&mPaintEngine; }
private:
PaintEngine mPaintEngine;
};
diff --git a/tests/auto/gui/image/qpixmap/tst_qpixmap.cpp b/tests/auto/gui/image/qpixmap/tst_qpixmap.cpp
index 24f10e559c..33e8671671 100644
--- a/tests/auto/gui/image/qpixmap/tst_qpixmap.cpp
+++ b/tests/auto/gui/image/qpixmap/tst_qpixmap.cpp
@@ -1063,7 +1063,7 @@ void tst_QPixmap::onlyNullPixmapsOutsideGuiThread()
class Thread : public QThread
{
public:
- void run()
+ void run() override
{
QTest::ignoreMessage(QtWarningMsg,
"QPixmap: It is not safe to use pixmaps outside the GUI thread");
diff --git a/tests/auto/gui/kernel/qbackingstore/tst_qbackingstore.cpp b/tests/auto/gui/kernel/qbackingstore/tst_qbackingstore.cpp
index 79c669753b..b2dc8ee035 100644
--- a/tests/auto/gui/kernel/qbackingstore/tst_qbackingstore.cpp
+++ b/tests/auto/gui/kernel/qbackingstore/tst_qbackingstore.cpp
@@ -53,12 +53,12 @@ public:
{
}
- void resizeEvent(QResizeEvent *)
+ void resizeEvent(QResizeEvent *) override
{
backingStore.resize(size());
}
- void exposeEvent(QExposeEvent *event)
+ void exposeEvent(QExposeEvent *event) override
{
QRect rect(QPoint(), size());
diff --git a/tests/auto/gui/kernel/qfileopenevent/test/tst_qfileopenevent.cpp b/tests/auto/gui/kernel/qfileopenevent/test/tst_qfileopenevent.cpp
index 43b2b79698..9da15b3e36 100644
--- a/tests/auto/gui/kernel/qfileopenevent/test/tst_qfileopenevent.cpp
+++ b/tests/auto/gui/kernel/qfileopenevent/test/tst_qfileopenevent.cpp
@@ -55,7 +55,7 @@ private:
QByteArray readFileContent(QFileOpenEvent& event);
bool appendFileContent(QFileOpenEvent& event, const QByteArray& writeContent);
- bool event(QEvent *);
+ bool event(QEvent *) override;
QTemporaryDir m_temporaryDir;
QString m_originalCurrent;
diff --git a/tests/auto/gui/kernel/qguiapplication/tst_qguiapplication.cpp b/tests/auto/gui/kernel/qguiapplication/tst_qguiapplication.cpp
index e0415441b9..b68f00ea46 100644
--- a/tests/auto/gui/kernel/qguiapplication/tst_qguiapplication.cpp
+++ b/tests/auto/gui/kernel/qguiapplication/tst_qguiapplication.cpp
@@ -186,7 +186,7 @@ class DummyWindow : public QWindow
public:
DummyWindow() : m_focusObject(nullptr) {}
- virtual QObject *focusObject() const
+ virtual QObject *focusObject() const override
{
return m_focusObject;
}
@@ -353,14 +353,14 @@ void tst_QGuiApplication::abortQuitOnShow()
class FocusChangeWindow: public QWindow
{
protected:
- virtual bool event(QEvent *ev)
+ virtual bool event(QEvent *ev) override
{
if (ev->type() == QEvent::FocusAboutToChange)
windowDuringFocusAboutToChange = qGuiApp->focusWindow();
return QWindow::event(ev);
}
- virtual void focusOutEvent(QFocusEvent *)
+ virtual void focusOutEvent(QFocusEvent *) override
{
windowDuringFocusOut = qGuiApp->focusWindow();
}
@@ -602,7 +602,7 @@ public:
inline explicit BlockableWindow(QWindow *parent = nullptr)
: QWindow(parent), blocked(false), leaves(0), enters(0) {}
- bool event(QEvent *e)
+ bool event(QEvent *e) override
{
switch (e->type()) {
case QEvent::WindowBlocked:
@@ -985,7 +985,7 @@ class TestPluginFactory : public QGenericPlugin
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QGenericPluginFactoryInterface" FILE "testplugin.json")
public:
- QObject* create(const QString &key, const QString &)
+ QObject* create(const QString &key, const QString &) override
{
if (key == "testplugin")
return new TestPlugin;
@@ -1003,7 +1003,7 @@ public:
: customEvents(0)
{}
- virtual void customEvent(QEvent *)
+ virtual void customEvent(QEvent *) override
{
customEvents++;
}
diff --git a/tests/auto/gui/kernel/qinputmethod/tst_qinputmethod.cpp b/tests/auto/gui/kernel/qinputmethod/tst_qinputmethod.cpp
index 15c905f943..d28dab3ad0 100644
--- a/tests/auto/gui/kernel/qinputmethod/tst_qinputmethod.cpp
+++ b/tests/auto/gui/kernel/qinputmethod/tst_qinputmethod.cpp
@@ -39,7 +39,7 @@ class InputItem : public QObject
public:
InputItem() : cursorRectangle(1, 2, 3, 4), m_enabled(true) {}
- bool event(QEvent *event)
+ bool event(QEvent *event) override
{
if (event->type() == QEvent::InputMethodQuery) {
QInputMethodQueryEvent *query = static_cast<QInputMethodQueryEvent *>(event);
@@ -74,7 +74,7 @@ class DummyWindow : public QWindow
public:
DummyWindow() : m_focusObject(0) {}
- virtual QObject *focusObject() const
+ virtual QObject *focusObject() const override
{
return m_focusObject;
}
diff --git a/tests/auto/gui/kernel/qkeyevent/tst_qkeyevent.cpp b/tests/auto/gui/kernel/qkeyevent/tst_qkeyevent.cpp
index 66160df21b..09becfe860 100644
--- a/tests/auto/gui/kernel/qkeyevent/tst_qkeyevent.cpp
+++ b/tests/auto/gui/kernel/qkeyevent/tst_qkeyevent.cpp
@@ -37,8 +37,8 @@ class Window : public QWindow
public:
~Window() { reset(); }
- void keyPressEvent(QKeyEvent *event) { recordEvent(event); }
- void keyReleaseEvent(QKeyEvent *event) { recordEvent(event); }
+ void keyPressEvent(QKeyEvent *event) override { recordEvent(event); }
+ void keyReleaseEvent(QKeyEvent *event) override { recordEvent(event); }
void reset() {
qDeleteAll(keyEvents.begin(), keyEvents.end());
diff --git a/tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp b/tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp
index 258ea0c85d..c0a0eb18f3 100644
--- a/tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp
+++ b/tests/auto/gui/kernel/qmouseevent/tst_qmouseevent.cpp
@@ -46,7 +46,7 @@ public:
int mouseReleaseButtons;
int mouseReleaseModifiers;
protected:
- void mousePressEvent(QMouseEvent *e)
+ void mousePressEvent(QMouseEvent *e) override
{
QWindow::mousePressEvent(e);
mousePressButton = e->button();
@@ -55,7 +55,7 @@ protected:
mousePressEventRecieved = true;
e->accept();
}
- void mouseReleaseEvent(QMouseEvent *e)
+ void mouseReleaseEvent(QMouseEvent *e) override
{
QWindow::mouseReleaseEvent(e);
mouseReleaseButton = e->button();
diff --git a/tests/auto/gui/kernel/qmouseevent_modal/tst_qmouseevent_modal.cpp b/tests/auto/gui/kernel/qmouseevent_modal/tst_qmouseevent_modal.cpp
index 758aeb42b9..c430148a91 100644
--- a/tests/auto/gui/kernel/qmouseevent_modal/tst_qmouseevent_modal.cpp
+++ b/tests/auto/gui/kernel/qmouseevent_modal/tst_qmouseevent_modal.cpp
@@ -88,7 +88,7 @@ public:
TstDialog( QWidget *mouseWidget, QWidget *parent, const char *name );
int count() { return c; }
protected:
- void showEvent ( QShowEvent * );
+ void showEvent(QShowEvent *) override;
public slots:
void releaseMouse();
void closeDialog();
diff --git a/tests/auto/gui/kernel/qwindow/tst_qwindow.cpp b/tests/auto/gui/kernel/qwindow/tst_qwindow.cpp
index dd0fb46eca..e84efa6ac3 100644
--- a/tests/auto/gui/kernel/qwindow/tst_qwindow.cpp
+++ b/tests/auto/gui/kernel/qwindow/tst_qwindow.cpp
@@ -402,7 +402,8 @@ public:
using Window::Window;
protected:
- void paintEvent(QPaintEvent *) {
+ void paintEvent(QPaintEvent *) override
+ {
// Handled, not calling base class
}
};
diff --git a/tests/auto/gui/painting/qpaintengine/tst_qpaintengine.cpp b/tests/auto/gui/painting/qpaintengine/tst_qpaintengine.cpp
index 64a6ce2939..d6b532887f 100644
--- a/tests/auto/gui/painting/qpaintengine/tst_qpaintengine.cpp
+++ b/tests/auto/gui/painting/qpaintengine/tst_qpaintengine.cpp
@@ -58,11 +58,11 @@ class MyPaintEngine : public QPaintEngine
{
public:
MyPaintEngine() : QPaintEngine() {}
- bool begin(QPaintDevice *) { return true; }
- bool end() { return true; }
- void updateState(const QPaintEngineState &) {}
- void drawPixmap(const QRectF &, const QPixmap &, const QRectF &) {}
- Type type() const { return Raster; }
+ bool begin(QPaintDevice *) override { return true; }
+ bool end() override { return true; }
+ void updateState(const QPaintEngineState &) override {}
+ void drawPixmap(const QRectF &, const QPixmap &, const QRectF &) override {}
+ Type type() const override { return Raster; }
};
// Testing get/set functions
diff --git a/tests/auto/gui/painting/qpainter/tst_qpainter.cpp b/tests/auto/gui/painting/qpainter/tst_qpainter.cpp
index 960dfdd04f..5d4e9def83 100644
--- a/tests/auto/gui/painting/qpainter/tst_qpainter.cpp
+++ b/tests/auto/gui/painting/qpainter/tst_qpainter.cpp
@@ -2634,17 +2634,17 @@ class DummyPaintEngine : public QPaintEngine, public QPaintDevice
{
public:
DummyPaintEngine() : QPaintEngine(no_porter_duff()) {}
- virtual bool begin(QPaintDevice *) { return true; }
- virtual bool end() { return true; }
+ virtual bool begin(QPaintDevice *) override { return true; }
+ virtual bool end() override { return true; }
- virtual void updateState(const QPaintEngineState &) {}
- virtual void drawPixmap(const QRectF &, const QPixmap &, const QRectF &) {}
+ virtual void updateState(const QPaintEngineState &) override {}
+ virtual void drawPixmap(const QRectF &, const QPixmap &, const QRectF &) override {}
- virtual Type type() const { return User; }
+ virtual Type type() const override { return User; }
- virtual QPaintEngine *paintEngine() const { return (QPaintEngine *)this; }
+ virtual QPaintEngine *paintEngine() const override { return (QPaintEngine *)this; }
- virtual int metric(PaintDeviceMetric metric) const { Q_UNUSED(metric); return 0; };
+ virtual int metric(PaintDeviceMetric metric) const override { Q_UNUSED(metric); return 0; };
};
static bool success;
@@ -2698,7 +2698,8 @@ class ViewportTestWidget : public QWidget
{
public:
ViewportTestWidget(QWidget *parent = 0) : QWidget(parent), hasPainted(false) {}
- QSize sizeHint() const {
+ QSize sizeHint() const override
+ {
return QSize(100, 100);
}
@@ -2706,7 +2707,8 @@ public:
bool hasPainted;
protected:
- void paintEvent(QPaintEvent *) {
+ void paintEvent(QPaintEvent *) override
+ {
hasPainted = true;
QPainter p(this);
viewport = p.viewport();
@@ -4451,7 +4453,7 @@ class TestProxy : public QGraphicsProxyWidget
{
public:
TestProxy() : QGraphicsProxyWidget() {}
- void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget)
+ void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget) override
{
QGraphicsProxyWidget::paint(painter, option, widget);
deviceTransform = painter->deviceTransform();
@@ -4464,7 +4466,7 @@ class TestWidget : public QWidget
Q_OBJECT
public:
TestWidget() : QWidget(), painted(false) {}
- void paintEvent(QPaintEvent *)
+ void paintEvent(QPaintEvent *) override
{
QPainter p(this);
deviceTransform = p.deviceTransform();
@@ -4645,7 +4647,7 @@ void tst_QPainter::drawPointScaled()
class GradientProducer : public QThread
{
protected:
- void run();
+ void run() override;
};
void GradientProducer::run()
@@ -4739,7 +4741,7 @@ void tst_QPainter::QTBUG38781_NoBrushAndQBitmap()
class TextDrawerThread : public QThread
{
public:
- void run();
+ void run() override;
QImage rendering;
};
diff --git a/tests/auto/gui/qopengl/tst_qopengl.cpp b/tests/auto/gui/qopengl/tst_qopengl.cpp
index 32c897e172..5e244a4ae9 100644
--- a/tests/auto/gui/qopengl/tst_qopengl.cpp
+++ b/tests/auto/gui/qopengl/tst_qopengl.cpp
@@ -150,14 +150,14 @@ struct SharedResource : public QOpenGLSharedResource
tracker->destructorCalls++;
}
- void invalidateResource()
+ void invalidateResource() override
{
resource = 0;
if (tracker)
tracker->invalidateResourceCalls++;
}
- void freeResource(QOpenGLContext *context)
+ void freeResource(QOpenGLContext *context) override
{
Q_ASSERT(context == QOpenGLContext::currentContext());
Q_UNUSED(context);
diff --git a/tests/auto/gui/text/qabstracttextdocumentlayout/tst_qabstracttextdocumentlayout.cpp b/tests/auto/gui/text/qabstracttextdocumentlayout/tst_qabstracttextdocumentlayout.cpp
index be3ef968ef..5e6f8ce946 100644
--- a/tests/auto/gui/text/qabstracttextdocumentlayout/tst_qabstracttextdocumentlayout.cpp
+++ b/tests/auto/gui/text/qabstracttextdocumentlayout/tst_qabstracttextdocumentlayout.cpp
@@ -72,13 +72,14 @@ public:
{
}
- void draw(QPainter *, const PaintContext &) {}
- int hitTest(const QPointF &, Qt::HitTestAccuracy) const { return 0; }
- int pageCount() const { return 0; }
- QSizeF documentSize() const { return QSizeF(); }
- QRectF frameBoundingRect(QTextFrame *) const { return QRectF(); }
- QRectF blockBoundingRect(const QTextBlock &) const { return QRectF(); }
- void documentChanged(int from, int /* oldLength */, int length) {
+ void draw(QPainter *, const PaintContext &) override {}
+ int hitTest(const QPointF &, Qt::HitTestAccuracy) const override { return 0; }
+ int pageCount() const override { return 0; }
+ QSizeF documentSize() const override { return QSizeF(); }
+ QRectF frameBoundingRect(QTextFrame *) const override { return QRectF(); }
+ QRectF blockBoundingRect(const QTextBlock &) const override { return QRectF(); }
+ void documentChanged(int from, int /* oldLength */, int length) override
+ {
++changeEvents;
QTextBlock last = document()->lastBlock();
diff --git a/tests/auto/gui/text/qcssparser/tst_qcssparser.cpp b/tests/auto/gui/text/qcssparser/tst_qcssparser.cpp
index a01805236a..0c7e53b4fa 100644
--- a/tests/auto/gui/text/qcssparser/tst_qcssparser.cpp
+++ b/tests/auto/gui/text/qcssparser/tst_qcssparser.cpp
@@ -887,30 +887,30 @@ public:
styleSheets.append(sheet);
}
- virtual QStringList nodeNames(NodePtr node) const { return QStringList(reinterpret_cast<QDomElement *>(node.ptr)->tagName()); }
- virtual QString attribute(NodePtr node, const QString &name) const { return reinterpret_cast<QDomElement *>(node.ptr)->attribute(name); }
+ virtual QStringList nodeNames(NodePtr node) const override { return QStringList(reinterpret_cast<QDomElement *>(node.ptr)->tagName()); }
+ virtual QString attribute(NodePtr node, const QString &name) const override { return reinterpret_cast<QDomElement *>(node.ptr)->attribute(name); }
virtual bool hasAttribute(NodePtr node, const QString &name) const { return reinterpret_cast<QDomElement *>(node.ptr)->hasAttribute(name); }
- virtual bool hasAttributes(NodePtr node) const { return reinterpret_cast<QDomElement *>(node.ptr)->hasAttributes(); }
+ virtual bool hasAttributes(NodePtr node) const override { return reinterpret_cast<QDomElement *>(node.ptr)->hasAttributes(); }
- virtual bool isNullNode(NodePtr node) const {
+ virtual bool isNullNode(NodePtr node) const override {
return reinterpret_cast<QDomElement *>(node.ptr)->isNull();
}
- virtual NodePtr parentNode(NodePtr node) const {
+ virtual NodePtr parentNode(NodePtr node) const override {
NodePtr parent;
parent.ptr = new QDomElement(reinterpret_cast<QDomElement *>(node.ptr)->parentNode().toElement());
return parent;
}
- virtual NodePtr duplicateNode(NodePtr node) const {
+ virtual NodePtr duplicateNode(NodePtr node) const override {
NodePtr n;
n.ptr = new QDomElement(*reinterpret_cast<QDomElement *>(node.ptr));
return n;
}
- virtual NodePtr previousSiblingNode(NodePtr node) const {
+ virtual NodePtr previousSiblingNode(NodePtr node) const override {
NodePtr sibling;
sibling.ptr = new QDomElement(reinterpret_cast<QDomElement *>(node.ptr)->previousSiblingElement());
return sibling;
}
- virtual void freeNode(NodePtr node) const {
+ virtual void freeNode(NodePtr node) const override {
delete reinterpret_cast<QDomElement *>(node.ptr);
}
diff --git a/tests/auto/gui/text/qstatictext/tst_qstatictext.cpp b/tests/auto/gui/text/qstatictext/tst_qstatictext.cpp
index 645ff39cbe..8908d8b9d1 100644
--- a/tests/auto/gui/text/qstatictext/tst_qstatictext.cpp
+++ b/tests/auto/gui/text/qstatictext/tst_qstatictext.cpp
@@ -847,7 +847,7 @@ public:
TestPixmap(int w, int h) : QPixmap(w, h), testPaintEngine(new TestPaintEngine) {}
~TestPixmap() { delete testPaintEngine; }
- QPaintEngine *paintEngine() const
+ QPaintEngine *paintEngine() const override
{
return testPaintEngine;
}
diff --git a/tests/auto/gui/text/qsyntaxhighlighter/tst_qsyntaxhighlighter.cpp b/tests/auto/gui/text/qsyntaxhighlighter/tst_qsyntaxhighlighter.cpp
index 1301ccc9cf..da73e7846a 100644
--- a/tests/auto/gui/text/qsyntaxhighlighter/tst_qsyntaxhighlighter.cpp
+++ b/tests/auto/gui/text/qsyntaxhighlighter/tst_qsyntaxhighlighter.cpp
@@ -45,18 +45,18 @@ public:
inline QTestDocumentLayout(QTextDocument *doc)
: QAbstractTextDocumentLayout(doc), documentChangedCalled(false) {}
- virtual void draw(QPainter *, const QAbstractTextDocumentLayout::PaintContext &) {}
+ virtual void draw(QPainter *, const QAbstractTextDocumentLayout::PaintContext &) override {}
- virtual int hitTest(const QPointF &, Qt::HitTestAccuracy ) const { return 0; }
+ virtual int hitTest(const QPointF &, Qt::HitTestAccuracy ) const override { return 0; }
- virtual void documentChanged(int, int, int) { documentChangedCalled = true; }
+ virtual void documentChanged(int, int, int) override { documentChangedCalled = true; }
- virtual int pageCount() const { return 1; }
+ virtual int pageCount() const override { return 1; }
- virtual QSizeF documentSize() const { return QSize(); }
+ virtual QSizeF documentSize() const override { return QSize(); }
- virtual QRectF frameBoundingRect(QTextFrame *) const { return QRectF(); }
- virtual QRectF blockBoundingRect(const QTextBlock &) const { return QRectF(); }
+ virtual QRectF frameBoundingRect(QTextFrame *) const override { return QRectF(); }
+ virtual QRectF blockBoundingRect(const QTextBlock &) const override { return QRectF(); }
bool documentChangedCalled;
};
@@ -122,7 +122,7 @@ public:
inline TestHighlighter(QTextDocument *parent)
: QSyntaxHighlighter(parent), highlighted(false), callCount(0) {}
- virtual void highlightBlock(const QString &text)
+ virtual void highlightBlock(const QString &text) override
{
for (int i = 0; i < formats.count(); ++i) {
const QTextLayout::FormatRange &range = formats.at(i);
@@ -179,7 +179,7 @@ public:
highlighted = false;
}
- virtual void highlightBlock(const QString &text)
+ virtual void highlightBlock(const QString &text) override
{
QTextCharFormat commentFormat;
commentFormat.setForeground(Qt::darkGreen);
@@ -294,7 +294,7 @@ public:
state = 0;
}
- virtual void highlightBlock(const QString &text)
+ virtual void highlightBlock(const QString &text) override
{
highlighted = true;
if (text == QLatin1String("changestate"))
diff --git a/tests/auto/gui/text/qtextdocument/common.h b/tests/auto/gui/text/qtextdocument/common.h
index 0681f7f0e2..11ad99cfa0 100644
--- a/tests/auto/gui/text/qtextdocument/common.h
+++ b/tests/auto/gui/text/qtextdocument/common.h
@@ -36,10 +36,10 @@ class QTestDocumentLayout : public QAbstractTextDocumentLayout
Q_OBJECT
public:
QTestDocumentLayout(QTextDocument *doc) : QAbstractTextDocumentLayout(doc), f(-1), called(false) {}
- virtual void draw(QPainter *, const PaintContext &) {}
- virtual int hitTest(const QPointF &, Qt::HitTestAccuracy ) const { return 0; }
+ virtual void draw(QPainter *, const PaintContext &) override {}
+ virtual int hitTest(const QPointF &, Qt::HitTestAccuracy ) const override { return 0; }
- virtual void documentChanged(int from, int oldLength, int length)
+ virtual void documentChanged(int from, int oldLength, int length) override
{
called = true;
lastDocumentLengths.append(QTextDocumentPrivate::get(document())->length());
@@ -55,11 +55,11 @@ public:
}
}
- virtual int pageCount() const { return 1; }
- virtual QSizeF documentSize() const { return QSizeF(); }
+ virtual int pageCount() const override { return 1; }
+ virtual QSizeF documentSize() const override { return QSizeF(); }
- virtual QRectF frameBoundingRect(QTextFrame *) const { return QRectF(); }
- virtual QRectF blockBoundingRect(const QTextBlock &) const { return QRectF(); }
+ virtual QRectF frameBoundingRect(QTextFrame *) const override { return QRectF(); }
+ virtual QRectF blockBoundingRect(const QTextBlock &) const override { return QRectF(); }
int f;
int o;
diff --git a/tests/auto/gui/text/qtextdocument/tst_qtextdocument.cpp b/tests/auto/gui/text/qtextdocument/tst_qtextdocument.cpp
index 04f8a9aa38..aaa3433173 100644
--- a/tests/auto/gui/text/qtextdocument/tst_qtextdocument.cpp
+++ b/tests/auto/gui/text/qtextdocument/tst_qtextdocument.cpp
@@ -209,13 +209,13 @@ class MyAbstractTextDocumentLayout : public QAbstractTextDocumentLayout
{
public:
MyAbstractTextDocumentLayout(QTextDocument *doc) : QAbstractTextDocumentLayout(doc) {}
- void draw(QPainter *, const PaintContext &) {}
- int hitTest(const QPointF &, Qt::HitTestAccuracy) const { return 0; }
- int pageCount() const { return 0; }
- QSizeF documentSize() const { return QSizeF(); }
- QRectF frameBoundingRect(QTextFrame *) const { return QRectF(); }
- QRectF blockBoundingRect(const QTextBlock &) const { return QRectF(); }
- void documentChanged(int, int, int) {}
+ void draw(QPainter *, const PaintContext &) override {}
+ int hitTest(const QPointF &, Qt::HitTestAccuracy) const override { return 0; }
+ int pageCount() const override { return 0; }
+ QSizeF documentSize() const override { return QSizeF(); }
+ QRectF frameBoundingRect(QTextFrame *) const override { return QRectF(); }
+ QRectF blockBoundingRect(const QTextBlock &) const override { return QRectF(); }
+ void documentChanged(int, int, int) override {}
};
QString tst_QTextDocument::cssFontSizeString(const QFont &font)
@@ -2384,7 +2384,7 @@ public:
bool hasResourceCached();
protected:
- virtual QVariant loadResource(int type, const QUrl &name);
+ virtual QVariant loadResource(int type, const QUrl &name) override;
private:
QUrl url;
@@ -3185,7 +3185,7 @@ class BaseDocument : public QTextDocument
public:
QUrl loadedResource() const { return resourceUrl; }
- QVariant loadResource(int type, const QUrl &name)
+ QVariant loadResource(int type, const QUrl &name) override
{
resourceUrl = name;
return QTextDocument::loadResource(type, name);
diff --git a/tests/auto/gui/text/qtextdocumentfragment/tst_qtextdocumentfragment.cpp b/tests/auto/gui/text/qtextdocumentfragment/tst_qtextdocumentfragment.cpp
index 159effbd8f..3fdfa8ae99 100644
--- a/tests/auto/gui/text/qtextdocumentfragment/tst_qtextdocumentfragment.cpp
+++ b/tests/auto/gui/text/qtextdocumentfragment/tst_qtextdocumentfragment.cpp
@@ -3134,7 +3134,8 @@ public:
QPixmap testPixmap;
- virtual QVariant loadResource(int type, const QUrl &name) {
+ virtual QVariant loadResource(int type, const QUrl &name) override
+ {
if (name.toString() == QLatin1String("testPixmap")) {
return testPixmap;
}
diff --git a/tests/auto/gui/text/qtextlayout/tst_qtextlayout.cpp b/tests/auto/gui/text/qtextlayout/tst_qtextlayout.cpp
index afcae2f4b7..f00d6215c3 100644
--- a/tests/auto/gui/text/qtextlayout/tst_qtextlayout.cpp
+++ b/tests/auto/gui/text/qtextlayout/tst_qtextlayout.cpp
@@ -1683,8 +1683,8 @@ QT_END_NAMESPACE
void tst_QTextLayout::testTabDPIScale()
{
class MyPaintDevice : public QPaintDevice {
- QPaintEngine *paintEngine () const { return 0; }
- int metric (QPaintDevice::PaintDeviceMetric metric) const {
+ QPaintEngine *paintEngine () const override { return 0; }
+ int metric (QPaintDevice::PaintDeviceMetric metric) const override {
switch(metric) {
case QPaintDevice::PdmWidth:
case QPaintDevice::PdmHeight:
diff --git a/tests/auto/gui/text/qtexttable/tst_qtexttable.cpp b/tests/auto/gui/text/qtexttable/tst_qtexttable.cpp
index 2b0236339c..a848dad3d8 100644
--- a/tests/auto/gui/text/qtexttable/tst_qtexttable.cpp
+++ b/tests/auto/gui/text/qtexttable/tst_qtexttable.cpp
@@ -1043,30 +1043,30 @@ public:
PaintEngine()
: QPaintEngine(QPaintEngine::PaintEngineFeatures{ })
{}
- virtual Type type() const
+ virtual Type type() const override
{
return User;
}
- virtual bool begin(QPaintDevice *)
+ virtual bool begin(QPaintDevice *) override
{
return true;
}
- virtual bool end()
+ virtual bool end() override
{
return true;
}
- virtual void updateState(const QPaintEngineState &)
+ virtual void updateState(const QPaintEngineState &) override
{}
- virtual void drawRects(const QRect *, int)
+ virtual void drawRects(const QRect *, int) override
{}
- virtual void drawRects(const QRectF *r, int)
+ virtual void drawRects(const QRectF *r, int) override
{
if (painter()->brush() == QBrush(Qt::green))
{
rects.append(*r);
}
}
- virtual void drawPixmap(const QRectF &, const QPixmap &, const QRectF &)
+ virtual void drawPixmap(const QRectF &, const QPixmap &, const QRectF &) override
{}
};
@@ -1115,7 +1115,7 @@ public:
layout.setUnits(QPageLayout::Point);
setPageLayout(layout);
}
- virtual int metric(PaintDeviceMetric metric) const
+ virtual int metric(PaintDeviceMetric metric) const override
{
if (PdmDevicePixelRatio == metric)
return 1;
@@ -1131,11 +1131,11 @@ public:
return 700;
return 900;
}
- virtual QPaintEngine *paintEngine() const
+ virtual QPaintEngine *paintEngine() const override
{
return engine;
}
- bool newPage()
+ bool newPage() override
{
++pages;
return true;
diff --git a/tests/auto/gui/util/qundogroup/tst_qundogroup.cpp b/tests/auto/gui/util/qundogroup/tst_qundogroup.cpp
index 617e0239e1..5f82bd8442 100644
--- a/tests/auto/gui/util/qundogroup/tst_qundogroup.cpp
+++ b/tests/auto/gui/util/qundogroup/tst_qundogroup.cpp
@@ -40,8 +40,8 @@ public:
InsertCommand(QString *str, int idx, const QString &text,
QUndoCommand *parent = 0);
- virtual void undo();
- virtual void redo();
+ virtual void undo() override;
+ virtual void redo() override;
private:
QString *m_str;
@@ -54,8 +54,8 @@ class RemoveCommand : public QUndoCommand
public:
RemoveCommand(QString *str, int idx, int len, QUndoCommand *parent = 0);
- virtual void undo();
- virtual void redo();
+ virtual void undo() override;
+ virtual void redo() override;
private:
QString *m_str;
@@ -68,10 +68,10 @@ class AppendCommand : public QUndoCommand
public:
AppendCommand(QString *str, const QString &text, QUndoCommand *parent = 0);
- virtual void undo();
- virtual void redo();
- virtual int id() const;
- virtual bool mergeWith(const QUndoCommand *other);
+ virtual void undo() override;
+ virtual void redo() override;
+ virtual int id() const override;
+ virtual bool mergeWith(const QUndoCommand *other) override;
bool merged;
diff --git a/tests/auto/gui/util/qundostack/tst_qundostack.cpp b/tests/auto/gui/util/qundostack/tst_qundostack.cpp
index a24798cba7..9415f1325c 100644
--- a/tests/auto/gui/util/qundostack/tst_qundostack.cpp
+++ b/tests/auto/gui/util/qundostack/tst_qundostack.cpp
@@ -41,8 +41,8 @@ public:
InsertCommand(QString *str, int idx, const QString &text,
QUndoCommand *parent = 0);
- virtual void undo();
- virtual void redo();
+ virtual void undo() override;
+ virtual void redo() override;
private:
QString *m_str;
@@ -55,8 +55,8 @@ class RemoveCommand : public QUndoCommand
public:
RemoveCommand(QString *str, int idx, int len, QUndoCommand *parent = 0);
- virtual void undo();
- virtual void redo();
+ virtual void undo() override;
+ virtual void redo() override;
private:
QString *m_str;
@@ -71,10 +71,10 @@ public:
QUndoCommand *parent = 0);
~AppendCommand();
- virtual void undo();
- virtual void redo();
- virtual int id() const;
- virtual bool mergeWith(const QUndoCommand *other);
+ virtual void undo() override;
+ virtual void redo() override;
+ virtual int id() const override;
+ virtual bool mergeWith(const QUndoCommand *other) override;
bool merged;
bool fail_merge;
@@ -91,8 +91,8 @@ public:
IdleCommand(QUndoCommand *parent = 0);
~IdleCommand();
- virtual void undo();
- virtual void redo();
+ virtual void undo() override;
+ virtual void redo() override;
};
class MoveMouseCommand : public QUndoCommand
@@ -101,10 +101,10 @@ public:
MoveMouseCommand(QPoint *mouse, QPoint oldPoint, QPoint newPoint, QUndoCommand *parent = 0);
~MoveMouseCommand();
- virtual void undo();
- virtual void redo();
- virtual int id() const;
- virtual bool mergeWith(const QUndoCommand *other);
+ virtual void undo() override;
+ virtual void redo() override;
+ virtual int id() const override;
+ virtual bool mergeWith(const QUndoCommand *other) override;
private:
QPoint *m_mouse;