QtNetwork auto tests: port Q_FOREACH to ranged-for [4]

Straightforward ports where the container could be made const.

Use C arrays instead of QList if the data is known at compile time.

Drive-by, where appropriate make the for-loop variable a const& (e.g.
QString) instead of copying it for no reason.

Task-number: QTBUG-115839
Change-Id: I273a386e414e5923e750072f0407226efcd4531e
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>

1 files changed, 8 insertions, 8 deletions

diff --git a/tests/auto/network/access/qnetworkdiskcache/tst_qnetworkdiskcache.cpp b/tests/auto/network/access/qnetworkdiskcache/tst_qnetworkdiskcache.cpp
index f6edf61e73..5f0bf9ef60 100644
--- a/tests/auto/network/access/qnetworkdiskcache/tst_qnetworkdiskcache.cpp
+++ b/tests/auto/network/access/qnetworkdiskcache/tst_qnetworkdiskcache.cpp
@@ -478,9 +478,9 @@ void tst_QNetworkDiskCache::fileMetaData()
     url.setFragment(QString());
 
     QString cacheDirectory = cache.cacheDirectory();
-    QStringList list = countFiles(cacheDirectory);
+    const QStringList list = countFiles(cacheDirectory);
     QCOMPARE(list.size(), NUM_SUBDIRECTORIES + 3);
-    foreach(QString fileName, list) {
+    for (const QString &fileName : list) {
         QFileInfo info(fileName);
         if (info.isFile()) {
             QNetworkCacheMetaData metaData = cache.call_fileMetaData(fileName);
@@ -523,9 +523,9 @@ void tst_QNetworkDiskCache::expire()
     }
 
     QString cacheDirectory = cache.cacheDirectory();
-    QStringList list = countFiles(cacheDirectory);
+    const QStringList list = countFiles(cacheDirectory);
     QStringList cacheList;
-    foreach(QString fileName, list) {
+    for (const QString &fileName : list) {
         QFileInfo info(fileName);
         if (info.isFile()) {
             QNetworkCacheMetaData metaData = cache.call_fileMetaData(fileName);
@@ -571,11 +571,11 @@ void tst_QNetworkDiskCache::oldCacheVersionFile()
         QVERIFY(!metaData.isValid());
         QVERIFY(!QFile::exists(name));
     } else {
-        QStringList files = countFiles(cache.cacheDirectory());
+        const QStringList files = countFiles(cache.cacheDirectory());
         QCOMPARE(files.size(), NUM_SUBDIRECTORIES + 3);
         // find the file
         QString cacheFile;
-        foreach (QString file, files) {
+        for (const QString &file : files) {
             QFileInfo info(file);
             if (info.isFile())
                 cacheFile = file;
@@ -612,8 +612,8 @@ void tst_QNetworkDiskCache::streamVersion()
 
     QString cacheFile;
     // find the file
-    QStringList files = countFiles(cache.cacheDirectory());
-    foreach (const QString &file, files) {
+    const QStringList files = countFiles(cache.cacheDirectory());
+    for (const QString &file : files) {
         QFileInfo info(file);
         if (info.isFile()) {
             cacheFile = file;