summaryrefslogtreecommitdiffstats
path: root/tests/auto/network/access
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@qt.io>2024-04-18 08:59:43 +0200
committerMarc Mutz <marc.mutz@qt.io>2024-04-18 19:06:02 +0200
commit5b6c6dab632a32a09963453b08731e9e33334e9a (patch)
tree114ba79a1eb1bd191fa7c2b53b58e18a314f8327 /tests/auto/network/access
parentd4aaf61b3333b48b4e79ad60b63bb50dbea72617 (diff)
tst_QRestAccessManager: fix signature of server handlers
HttpTestServer::Handler is declared to take the first argument by reference to const, not by value, so use the same parameter passing for the lambdas passed to setHandler(). Avoids copying the (rather large) argument when invoked through the std::function wrapper, and silences clazy-function-args-by-ref. Pick-to: 6.7 Change-Id: I726d0b98a7fcb3b1b33c5bde203035f593c39bdd Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Diffstat (limited to 'tests/auto/network/access')
-rw-r--r--tests/auto/network/access/qrestaccessmanager/tst_qrestaccessmanager.cpp12
1 files changed, 6 insertions, 6 deletions
diff --git a/tests/auto/network/access/qrestaccessmanager/tst_qrestaccessmanager.cpp b/tests/auto/network/access/qrestaccessmanager/tst_qrestaccessmanager.cpp
index 2f3ffaac33..602bffd9c1 100644
--- a/tests/auto/network/access/qrestaccessmanager/tst_qrestaccessmanager.cpp
+++ b/tests/auto/network/access/qrestaccessmanager/tst_qrestaccessmanager.cpp
@@ -109,7 +109,7 @@ void tst_QRestAccessManager::requests()
HttpData serverSideRequest; // The request data the server received
HttpData serverSideResponse; // The response data the server responds with
serverSideResponse.status = 200;
- server.setHandler([&](HttpData request, HttpData &response, ResponseControl&) {
+ server.setHandler([&](const HttpData &request, HttpData &response, ResponseControl&) {
serverSideRequest = request;
response = serverSideResponse;
@@ -473,7 +473,7 @@ void tst_QRestAccessManager::errors()
QNetworkRequest request(server.url());
HttpData serverSideResponse; // The response data the server responds with
- server.setHandler([&](HttpData, HttpData &response, ResponseControl &) {
+ server.setHandler([&](const HttpData &, HttpData &response, ResponseControl &) {
response = serverSideResponse;
});
@@ -540,7 +540,7 @@ void tst_QRestAccessManager::body()
HttpData serverSideRequest; // The request data the server received
HttpData serverSideResponse; // The response data the server responds with
- server.setHandler([&](HttpData request, HttpData &response, ResponseControl&) {
+ server.setHandler([&](const HttpData &request, HttpData &response, ResponseControl&) {
serverSideRequest = request;
response = serverSideResponse;
});
@@ -601,7 +601,7 @@ void tst_QRestAccessManager::json()
HttpData serverSideRequest; // The request data the server received
HttpData serverSideResponse; // The response data the server responds with
serverSideResponse.status = 200;
- server.setHandler([&](HttpData request, HttpData &response, ResponseControl&) {
+ server.setHandler([&](const HttpData &request, HttpData &response, ResponseControl&) {
serverSideRequest = request;
response = serverSideResponse;
});
@@ -709,7 +709,7 @@ void tst_QRestAccessManager::text()
HttpData serverSideRequest; // The request data the server received
HttpData serverSideResponse; // The response data the server responds with
serverSideResponse.status = 200;
- server.setHandler([&](HttpData request, HttpData &response, ResponseControl&) {
+ server.setHandler([&](const HttpData &request, HttpData &response, ResponseControl&) {
serverSideRequest = request;
response = serverSideResponse;
});
@@ -801,7 +801,7 @@ void tst_QRestAccessManager::textStreaming()
serverSideResponse.body = encUTF8(expectedData);
serverSideResponse.status = 200;
- server.setHandler([&](HttpData, HttpData &response, ResponseControl &control) {
+ server.setHandler([&](const HttpData &, HttpData &response, ResponseControl &control) {
response = serverSideResponse;
responseControl = &control; // store for later
control.responseChunkSize = 5; // tell testserver to send data in chunks of this size