qputenv: port to QByteArrayView

The vast majority of in-tree users pass simple and short C string
literals as the value. By porting to QByteArrayView, we document that
we'll accept non-NUL-terminated data, and do the NUL-termination
internally, using SSO'ed std::string, saving memory allocations in the
common case of short strings.

I didn't bother to check which direction std::string takes for
nullptrs these days (there was a change accepted in that area for
C++20 or 23), so play it safe and protect against them.

Follow-up to

Task-number: QTBUG-105302
Change-Id: I2369acc62f1d5cbc26135396cfe0602d8c75300c
Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>

1 files changed, 5 insertions, 5 deletions

diff --git a/tests/auto/network/access/http2/tst_http2.cpp b/tests/auto/network/access/http2/tst_http2.cpp
index 8207f65dcd..bb2437c7f5 100644
--- a/tests/auto/network/access/http2/tst_http2.cpp
+++ b/tests/auto/network/access/http2/tst_http2.cpp
@@ -238,7 +238,7 @@ void tst_Http2::singleRequest()
     // we have to use TLS sockets (== private key) and thus suppress a
     // keychain UI asking for permission to use a private key.
     // Our CI has this, but somebody testing locally - will have a problem.
-    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", QByteArray("1"));
+    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", "1");
     auto envRollback = qScopeGuard([](){
         qunsetenv("QT_SSL_USE_TEMPORARY_KEYCHAIN");
     });
@@ -630,7 +630,7 @@ void tst_Http2::connectToHost()
     // we have to use TLS sockets (== private key) and thus suppress a
     // keychain UI asking for permission to use a private key.
     // Our CI has this, but somebody testing locally - will have a problem.
-    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", QByteArray("1"));
+    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", "1");
     auto envRollback = qScopeGuard([](){
         qunsetenv("QT_SSL_USE_TEMPORARY_KEYCHAIN");
     });
@@ -728,7 +728,7 @@ void tst_Http2::maxFrameSize()
     // we have to use TLS sockets (== private key) and thus suppress a
     // keychain UI asking for permission to use a private key.
     // Our CI has this, but somebody testing locally - will have a problem.
-    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", QByteArray("1"));
+    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", "1");
     auto envRollback = qScopeGuard([](){
         qunsetenv("QT_SSL_USE_TEMPORARY_KEYCHAIN");
     });
@@ -893,7 +893,7 @@ void tst_Http2::moreActivitySignals()
     // we have to use TLS sockets (== private key) and thus suppress a
     // keychain UI asking for permission to use a private key.
     // Our CI has this, but somebody testing locally - will have a problem.
-    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", QByteArray("1"));
+    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", "1");
     auto envRollback = qScopeGuard([]() { qunsetenv("QT_SSL_USE_TEMPORARY_KEYCHAIN"); });
 #endif
 
@@ -1004,7 +1004,7 @@ void tst_Http2::contentEncoding()
     // we have to use TLS sockets (== private key) and thus suppress a
     // keychain UI asking for permission to use a private key.
     // Our CI has this, but somebody testing locally - will have a problem.
-    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", QByteArray("1"));
+    qputenv("QT_SSL_USE_TEMPORARY_KEYCHAIN", "1");
     auto envRollback = qScopeGuard([]() { qunsetenv("QT_SSL_USE_TEMPORARY_KEYCHAIN"); });
 #endif